Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][cocoapods] remove all instances of is_string in options and use type #18850

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • is_string is slowly being replaced by type to make the docs clearer, options safer, and Swift generation more correct.
  • This PR does this for only cocoapods action.

Description

  • Remove is_string: true from options
  • Added type: Boolean

Testing Steps

  • No functionality changed, all existing/new unit tests should pass.

@google-cla google-cla bot added the cla: yes label Jun 11, 2021
Comment on lines -114 to -115
type: :string_callback,
default_value: nil),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string_callback 🤯
Q: do I need to keep default_value: nil for this type? 🤔
(My logic is because this param has optional: true, so we don't need default_value: nil but I could be wrong too...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: true should be all that we need here 💪

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@joshdholtz joshdholtz merged commit 7882b53 into master Jun 11, 2021
@joshdholtz joshdholtz deleted the crazymanish-cocoapods-clean-up branch June 11, 2021 18:19
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants