-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action][create_pull_request] remove all instances of is_string
in options and use type
#18858
Conversation
…options and use `type`
@@ -210,21 +205,17 @@ def self.available_options | |||
FastlaneCore::ConfigItem.new(key: :head, | |||
env_name: "GITHUB_PULL_REQUEST_HEAD", | |||
description: "The name of the branch where your changes are implemented (defaults to the current branch name)", | |||
is_string: true, | |||
code_gen_sensitive: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch name was code_gen_sensitive
🤨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@@ -210,21 +205,17 @@ def self.available_options | |||
FastlaneCore::ConfigItem.new(key: :head, | |||
env_name: "GITHUB_PULL_REQUEST_HEAD", | |||
description: "The name of the branch where your changes are implemented (defaults to the current branch name)", | |||
is_string: true, | |||
code_gen_sensitive: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why 🤷♂️
Hey @crazymanish 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
is_string
is slowly being replaced bytype
to make the docs clearer, options safer, and Swift generation more correct.create_pull_request
action.Description
is_string: true
from optionsTesting Steps