Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action][validate_play_store_json_key] fix the Options formatting #19030

Merged
merged 1 commit into from
Jul 2, 2021
Merged

[action][validate_play_store_json_key] fix the Options formatting #19030

merged 1 commit into from
Jul 2, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • Options formatting was slightly off.

Description

  • fix Options formatting

Testing Steps

  • No functionality changed, all existing unit tests should pass.

@google-cla google-cla bot added the cla: yes label Jun 29, 2021
crazymanish
crazymanish commented Jun 29, 2021
View reviewed changes
fastlane/lib/fastlane/actions/validate_play_store_json_key.rb
env_name: "SUPPLY_JSON_KEY",
short_option: "-j",
conflicting_options: [:json_key_data],
optional: true, # this shouldn't be optional but is until I find out how json_key OR json_key_data can be required
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this comment because we already have conflicting_options in the place that is same as other actions...

joshdholtz
joshdholtz approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@joshdholtz joshdholtz merged commit 5650e06 into master Jul 2, 2021
@joshdholtz joshdholtz deleted the crazymanish-validate_play_store_json_key-clean-up branch July 2, 2021 13:11
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Jul 22, 2021
Merged
@fastlane fastlane locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: included-in-next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazymanish @fastlane-bot @joshdholtz