-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] gradle: Update for GRADLE_OUTPUT_JSON_OUTPUT_PATH and GRADLE… #19038
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! One small change request to make this backwards compatible by wildcarding the output*.json
😊
…_ALL_OUTPUT_JSON_OUTPUT_PATHS in Android studio 4+ The output.json file has been rename to output-metadata.json in Android studio 4+
Co-authored-by: Josh Holtz <josh@rokkincat.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good now! Thanks again for fixing this ❤️ Really appreciate it!
Hey @mrkazansky 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.188.0 🚀
…_ALL_OUTPUT_JSON_OUTPUT_PATHS in Android studio 4+
The output.json file has been rename to output-metadata.json in Android studio 4+
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I need to read meta data from this file, but this one has renamed
Description
The old shared value (GRADLE_OUTPUT_JSON_OUTPUT_PATH || GRADLE_ALL_OUTPUT_JSON_OUTPUT_PATHS) is outdated, need to update with new file name
Testing Steps