Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] gradle: Update for GRADLE_OUTPUT_JSON_OUTPUT_PATH and GRADLE… #19038

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

mrkazansky
Copy link
Contributor

@mrkazansky mrkazansky commented Jul 1, 2021

…_ALL_OUTPUT_JSON_OUTPUT_PATHS in Android studio 4+

The output.json file has been rename to output-metadata.json in Android studio 4+

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I need to read meta data from this file, but this one has renamed

Description

The old shared value (GRADLE_OUTPUT_JSON_OUTPUT_PATH || GRADLE_ALL_OUTPUT_JSON_OUTPUT_PATHS) is outdated, need to update with new file name

Testing Steps

@google-cla
Copy link

google-cla bot commented Jul 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 1, 2021
@mrkazansky
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 1, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! One small change request to make this backwards compatible by wildcarding the output*.json 😊

fastlane/lib/fastlane/actions/gradle.rb Outdated Show resolved Hide resolved
mrkazansky and others added 2 commits July 12, 2021 06:04
…_ALL_OUTPUT_JSON_OUTPUT_PATHS in Android studio 4+

The output.json file has been rename to output-metadata.json in Android studio 4+
Co-authored-by: Josh Holtz <josh@rokkincat.com>
@google-cla
Copy link

google-cla bot commented Jul 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 12, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 12, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good now! Thanks again for fixing this ❤️ Really appreciate it!

@joshdholtz joshdholtz merged commit 0badb99 into fastlane:master Jul 12, 2021
@fastlane-bot
Copy link

Hey @mrkazansky 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.188.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants