Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scan] add Success rate row to results #19468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mullerfrederik
Copy link

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This change adds Success rate row to results so user gains better idea how many (percentage) tests are passing/failing.

Description

Add new row when puts results.

@google-cla google-cla bot added the cla: yes label Oct 13, 2021
@joshdholtz joshdholtz changed the title [scan] Add Success rate row to results [scan] add Success rate row to results Oct 13, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the calculation here 🤷‍♂️

scan/lib/scan/runner.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants