[docs] fix typos, grammar issues and improve wording across the codebase, documentation and specs #19495

jsoref · 2021-10-20T02:44:54Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

Spelling errors result in all kinds of problems, including:

tests that don't test what authors think they're testing,
systems that are harder to use because the expected spelling doesn't work,
making it harder to search the code for an item

Description

This PR corrects misspellings identified by the check-spelling action.

Testing Steps

The misspellings have been reported at:

The action reports that the changes in this PR would make it happy:

round 1: jsoref@8501809
round 2: https://github.com/jsoref/fastlane/actions/runs/7338979372#summary-19982406290

jsoref

Most word corrections were picked by Google Sheets, but I stepped in at times, and all errors are my fault.

Testing.md

deliver/lib/deliver/options.rb

deliver/lib/deliver/sync_screenshots.rb

deliver/lib/deliver/upload_screenshots.rb

spaceship/lib/spaceship/connect_api/client.rb

spaceship/lib/spaceship/connect_api/tunes/tunes.rb

spaceship/lib/spaceship/tunes/app_details.rb

spaceship/lib/spaceship/tunes/build_details.rb

spaceship/spec/tunes/app_version_spec.rb

Kukurijek · 2022-03-07T10:24:51Z

Hi @jsoref!

I think this is a very good improvement 🚀

On the other hand PR is not small and there are a lot of things that need to be tested. Since there are currently conflicts in PR, can you rebase the master and resolve the conflicts please?

Thx 👍

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

.rubocop.yml

Testing.md

deliver/lib/deliver/options.rb

deliver/spec/commands_generator_spec.rb

gym/lib/gym/generators/package_command_generator_xcode7.rb

fastlane_core/spec/core_ext/shellwords_ext_spec.rb

gym/lib/gym/generators/package_command_generator_xcode7.rb

match/lib/match/storage/git_storage.rb

match/lib/match/storage/gitlab/client.rb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rogerluan

Just left a few more comments and this should be good to go 😊

deliver/lib/deliver/runner.rb

fastlane/swift/Fastlane.swift

fastlane_core/lib/fastlane_core/string_filters.rb

fastlane_core/spec/core_ext/shellwords_ext_spec.rb

gym/lib/gym/generators/package_command_generator_xcode7.rb

rogerluan · 2023-12-27T20:31:25Z

Also, could you check the CI failures? 🙏

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref

I looked at the CI failures -- what I saw was a bizarre caching behavior. I've searched and people have been tripping on it for years. I tried to quickly reproduce it in a simple repository and failed. I filed a ticket to circleci asking for help.

fastlane/swift/Fastlane.swift

jsoref · 2023-12-27T20:52:48Z

deliver/lib/deliver/runner.rb

@@ -55,7 +55,7 @@ def run
      verify_version if options[:app_version].to_s.length > 0 && !options[:skip_app_version_update]

      # Rejecting before upload meta
-      # Screenshots can not be update/deleted if in waiting for review
+      # Screenshots cannot be updated or deleted if the app is in the "waiting for review" state


fwiw, i have a rule (which I'm not using because it's too complicated) that generally complains about not...or because sometimes there should be a neither/nor pattern. But both (a) correctly applying a rule and (b) correctly describing the rule to catch incorrect cases are too hard, so I just cry a little bit when I see things like this.

I do agree that expanding the / is the right thing as is fixing the tense agreement.

I suspect this could be can be neither ... nor...while..., but that's really too much and I'd rather not deal w/ it in this PR.

I love your attention to detail, can we work together on more projects? 😆

rogerluan

This LGTM! 🚀

It looks like you're the creator of the tool you're using, is that right? I'd love to integrate this tool in other projects as well as this one for a continuous spellchecking in PRs and such would this be something you'd be interested in setting up, for this repo? 😊

Thanks for addressing all the comments and for bearing with the time it took for me to get to this PR 🙇 better late than never I guess? 😅

rogerluan · 2023-12-28T02:23:28Z

deliver/lib/deliver/runner.rb

@@ -55,7 +55,7 @@ def run
      verify_version if options[:app_version].to_s.length > 0 && !options[:skip_app_version_update]

      # Rejecting before upload meta
-      # Screenshots can not be update/deleted if in waiting for review
+      # Screenshots cannot be updated or deleted if the app is in the "waiting for review" state


I love your attention to detail, can we work together on more projects? 😆

jsoref · 2023-12-28T02:44:55Z

Yeah, I'm happy to create a PR for you once this merges. Do you have a real-time chat mechanism? it's helpful to talk over some of its knobs / show how it does things...

rogerluan · 2023-12-28T02:50:18Z

@jsoref you can find me at t.me/rogerluan if you're on Telegram :)?

We have an internal Slack too but its history gets deleted after 90 days… if you're not on telegram, shoot me your email and I can add you to Slack! 🙏

…ase, documentation and specs (fastlane#19495) * spelling: accept Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: acknowledge Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: adaptations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: already Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: attempts Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: available Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: backed up Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: boolean Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: build Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: candidate Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: capability Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: catch/return Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: characters Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: collapsible Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: command-line Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: commands Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: contains Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: convenient Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: copies Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: default Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: deleted Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: deprecated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: destination Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: directories Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: does Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: early Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: enqueued Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: error Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: evaluate Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: exclude Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: family Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: faraday Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: foo Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: function Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: groups Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: identifier Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: identifying Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: identities Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: ignore Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: individual Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: infrequent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: integer Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: mapping Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: milliseconds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: modified Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: multiple Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: normalized Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: original Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: originating Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: output Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: platform Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: portrait Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: practices Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: priority Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: probably Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: properly Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: provisioning Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: quote Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: reached Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: reenable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: rejected Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: representing Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: represents Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: returns Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: screenshot Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: screenshots Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: secondary Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: set Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: shuts down Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: signature Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: simplify Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: spaceship Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: specified Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: string if Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: studio Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: succeeds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: successfully Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: suppress Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: syntax Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: triggered Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unauthorized Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unique Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unprocessable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: upload Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: uploaded Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: verbose Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: version Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: whether Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: with Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: without Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * Use plural version of `env_names` and add backwards compatible env var identifiers. * Revert changes made to `Fastlane.swift` autogenerated file. * Improve wording. * Use plural version of `env_names` and add backwards compatible env var identifiers. * spelling: already Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: anymore Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: are Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: backed up Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: be Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: cannot Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: case-insensitive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: doubled Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: emulate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: entry Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: equal Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: every time Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exclude Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: existence Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: far, far Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fine-grained Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: gitlab Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: identifying Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: indicates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: macos Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: matching Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: minimally Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: parallel Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: perform Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: purchase Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resolution Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: respond Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: returns Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: shellwords Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sierra Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: squiggly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: still Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: through Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: universal Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unsuitable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: using Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: with Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: work around Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: workaround Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: working Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: data_for_app_store_versions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * Reverting changes to Fastlane.swift * Improving comment * spelling: time, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: of the dsym Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>

google-cla bot added the cla: yes label Oct 20, 2021

jsoref commented Oct 20, 2021

View reviewed changes

fastlane-bot added the status: needs-attention label Nov 3, 2021

jsoref added 26 commits March 7, 2022 09:07

spelling: accept

3bf7f65

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: acknowledge

9bd1dca

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: adaptations

a67b0db

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: already

9969075

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: attempts

40d46e8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: available

5c50ad5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: backed up

79851e7

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: boolean

3bd2a24

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: build

edc6f46

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: candidate

1b23dda

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: capability

fc025be

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: catch/return

b516b12

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: characters

b03c416

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: collapsible

4e33bdf

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: command-line

0286eec

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: commands

f7716e4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: contains

9deba02

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: convenient

7354c1d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: copies

6c0c07b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: default

f0332bb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: deleted

70bc6db

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: deprecated

3824e6e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: destination

5dcf2d0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: directories

920b3ac

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: does

0335d92

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: early

b0091fb

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 13 commits December 27, 2023 07:25

spelling: shellwords

4588f6b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: sierra

ad5e016

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: squiggly

1ec087a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: still

7019a8b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

6cd3a91

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: through

042ba5b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: universal

20c6aa3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsuitable

f250917

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: using

1171a6c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

010113c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: work around

8add265

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workaround

6f624a3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: working

83027ee

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Dec 27, 2023

View reviewed changes

spelling: data_for_app_store_versions

afdc397

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rogerluan requested changes Dec 27, 2023

View reviewed changes

jsoref added 4 commits December 27, 2023 15:41

Reverting changes to Fastlane.swift

452e147

Improving comment

2b1fc98

spelling: time,

6874012

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: of the dsym

3e373a5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Dec 27, 2023

View reviewed changes

jsoref requested a review from rogerluan December 28, 2023 01:31

rogerluan approved these changes Dec 28, 2023

View reviewed changes

rogerluan merged commit e4296f1 into fastlane:master Dec 28, 2023
2 checks passed

jsoref deleted the spelling branch December 28, 2023 02:55

joshdholtz mentioned this pull request Jan 2, 2024

Version bump to 2.218.0 #21760

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] fix typos, grammar issues and improve wording across the codebase, documentation and specs #19495

[docs] fix typos, grammar issues and improve wording across the codebase, documentation and specs #19495

jsoref commented Oct 20, 2021 •

edited

jsoref left a comment

Kukurijek commented Mar 7, 2022

rogerluan left a comment

rogerluan commented Dec 27, 2023

jsoref left a comment

jsoref Dec 27, 2023

rogerluan Dec 28, 2023

rogerluan left a comment

rogerluan Dec 28, 2023

jsoref commented Dec 28, 2023

rogerluan commented Dec 28, 2023

[docs] fix typos, grammar issues and improve wording across the codebase, documentation and specs #19495

[docs] fix typos, grammar issues and improve wording across the codebase, documentation and specs #19495

Conversation

jsoref commented Oct 20, 2021 • edited

Checklist

Motivation and Context

Description

Testing Steps

jsoref left a comment

Choose a reason for hiding this comment

Kukurijek commented Mar 7, 2022

rogerluan left a comment

Choose a reason for hiding this comment

rogerluan commented Dec 27, 2023

jsoref left a comment

Choose a reason for hiding this comment

jsoref Dec 27, 2023

Choose a reason for hiding this comment

rogerluan Dec 28, 2023

Choose a reason for hiding this comment

rogerluan left a comment

Choose a reason for hiding this comment

rogerluan Dec 28, 2023

Choose a reason for hiding this comment

jsoref commented Dec 28, 2023

rogerluan commented Dec 28, 2023

jsoref commented Oct 20, 2021 •

edited