-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] allow using a .xcode-version
file with xcversion
action
#19644
[action] allow using a .xcode-version
file with xcversion
action
#19644
Conversation
@rogerluan Added my changes if you don't mind reviewing this whenever you get a chance 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @joshdholtz ! 🚀 thanks for those improvements! Much better!
(and now I've learned how to implement a dynamic default value 😁 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank so much for doing all the heavy lifting on this PR 😊 This is a great change 🙌
Hey @rogerluan 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.199.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I felt the necessity to unify the implementation to a single
.xcode-version
file, making it consistent withxcode-install
itself, and ensure_xcode_version action.Description
This PR allows us to use a
.xcode-version
and omit the:version
parameter when invokingxcversion
action. It finds and reads the contents of a.xcode-version
file just like the ensure_xcode_version action does:fastlane/fastlane/lib/fastlane/actions/ensure_xcode_version.rb
Lines 9 to 23 in dac3164
Testing Steps
To test this branch, modify your Gemfile as:
And run
bundle install
to apply the changes.