[fastlane_core] use randomly generated filename(s) for -assetFile when uploading binaries to Testflight/App Store #19716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries with non-alphanumeric filename to Testflight/App Store
[deliver][pilot] use copied ipa/pkg for -assetFile when uploading binaries with non-alphanumeric filename to Testflight/App Store
dokimyj
changed the title
dokimyj
changed the title
joshdholtz
requested changes
Jan 5, 2022
There was a problem hiding this comment.
I did not realize this side effect 😱 I'm sorry for the issue!
I think instead of changing this in deliver and pilot, we could probably change this in https://github.com/fastlane/fastlane/blob/master/fastlane_core/lib/fastlane_core/itunes_transporter.rb#L504-L506
tmp_asset_path = File.join(Dir.tmpdir, File.basename(asset_path))to
require 'securerandom' # place at top of file
new_file_name = "#{SecureRandom.uuid}#{File.extname(asset_path)}"
tmp_asset_path = File.join(Dir.tmpdir, new_file_name)I didn't run this but I think this should do it 🙃
|
@joshdholtz Thanks for the comment! I'll take this change and test to see how it changes the behavior in |
|
@dokimyj Perfect! Let me know if you need anything from me 😊 Thanks! |
[test] fl-suggestion
dokimyj
changed the title
dokimyj
changed the title
|
Changed Fastlane core part instead(itms transporting portion) and it works perfect! It seems far more clear & works perfect! Logs for `upload_to_testflight`and Thanks for correcting tests! I thought I gotta change the code to work only when non-alphanumeric filename comes. |
dokimyj
changed the title
joshdholtz
approved these changes
Jan 13, 2022
|
Congratulations! 🎉 This was released as part of fastlane 2.200.0 🚀 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Resolves #19708
When trying to upload ipa file to Testflight / App Store, the upload process fails if the name of the ipa file is in multibytes.
(The error message shows the name of the ipa/pkg file as blank.)
You can reproduce the error by building your app with
output_name: <multibytechar>.ipaand trying uploading it to Testflight / App Store.This changed behavior would make deliver/pilot use .ipa/.pkg derived from
copy_ipa/copy_pkgmethods, which will be found from thepackage_path:.itmsp.If there is no
.ipa/.pkgfile in.itmsppath, deliver/pilot will useupload_ipa/upload_pkgas is.copy_ipa
copy_pkg
Description
SecureRandomto randomize the name of asset file(s) to be uploaded.asset_pathexists and.itmspis not forced.Acceptance test result: #19716 (comment)
Obsolete explanations (for fixing deliver/pilot collectively)
deliver/runner.rb, replaced the value of variableipa_path/pkg_pathwith the one(s) in theitmspfile.pilot/build_manager, replaced the value of variableoptions[:ipa]/options[:pkg]the same way above.upload_ipa/upload_pkg, not to change the values inside the hashoptions.options[:ipa/pkg]values if there is no file forasset_filein.itmsp.I tested the way I could reproduce the problem the related issue undergone, and succeeded
upload_to_testflight.Testing Steps
bundle exec rspec fastlane_core