[gym] correctly inherit OTHER_SWIFT_FLAGS when using option 'analyze_build_time' #19737
Conversation
icecrystal23
force-pushed
the
tracyk/other-swift-flags
branch
from
61e281e
to
18e1397
Compare
|
Ok, figured out that I had a REALLY old fork of fastlane and updated my PR. |
icecrystal23
force-pushed
the
tracyk/other-swift-flags
branch
from
18e1397
to
829cce2
Compare
joshdholtz
changed the title
| @@ -43,7 +43,7 @@ def options | |||
| options << "-scmProvider system" | |||
| end | |||
| options << config[:xcargs] if config[:xcargs] | |||
| options << "OTHER_SWIFT_FLAGS=\"-Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time] | |||
| options << "OTHER_SWIFT_FLAGS=\"\\\$(value) -Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time] | |||
There was a problem hiding this comment.
I'm not too familiar with this but is $(value) the same thing as $(inherited)? 🙃
There was a problem hiding this comment.
I don't know where or if there is official documentation for it, but $(value) expands to the current build setting value. So it's sort of the command-line equivalent of $(inherited)
There was a problem hiding this comment.
Ohhhhhh, cool cool! I see what this is doing now 🤯 Thank you for the explanation 🥰
|
Hey @icecrystal23 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.200.0 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests pass (well, sort of. Tests unrelated to my change were failing, but the test for the code I changed was passing when run in isolation)bundle exec rubocop -ato ensure the code style is validMotivation and Context
We had an issue with the Apollo SDK when using CocoaPods. Turns out the root cause of that bug was the OTHER_SWIFT_FLAGS not being successfully inherited here. See details of that bug here: apollographql/apollo-ios#2047
Description
Added an additional escape character to the $ on "$(inherited)" OTHER_SWIFT_FLAGS so that it successfully gets passed to xcodebuild rather than being evaluated too early.
Testing Steps
I tested
gymon an example project with a custom OTHER_SWIFT_FLAGS setting and ensured that the actualCompileSwiftSourcescommand in the build log had the custom flag in addition to the build time analysis ones.