Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action][get_version_number] get_version_number in xcode 13 project can't read version_number #19773

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[action][get_version_number] get_version_number in xcode 13 project can't read version_number #19773

merged 1 commit into from
Jan 13, 2022

Conversation

dejunDev
Copy link
Contributor

@dejunDev dejunDev commented Jan 10, 2022 •
edited

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

@dejunDev
Update get_version_number.rb
fad0b9e 
fix xcode13 plist.info can't contains key ["CFBundleShortVersionString"]
joshdholtz
joshdholtz approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for fixing this 😊

@joshdholtz joshdholtz changed the title [Action] get_version_number in xcode 13 project can't read version_number [action][get_version_number] get_version_number in xcode 13 project can't read version_number Jan 13, 2022
@joshdholtz joshdholtz merged commit bf117a1 into fastlane:master Jan 13, 2022
@joshdholtz joshdholtz mentioned this pull request Jan 13, 2022
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.200.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dejunDev @fastlane-bot @joshdholtz