-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pem][spaceship] update development push certificate type ID #19879
[pem][spaceship] update development push certificate type ID #19879
Conversation
@joshdholtz now I'm really out of my depth with all the build failures here. But it does look like Apple changed the type ID. |
Just a word of warning – AWS SNS is currently rejecting certificates created this way with:
|
Build fail most likely because you didn't update the specs @ |
when we are planning to push the fix? |
I'd love to help, but I'm not sure I can push code to @igor-makarov's fork. If I can do so, I could take care of updating the specs. |
The main question is whether we can just forget the old type ID - it's probably still going to appear for old certificates. |
fca82e8
to
0992ad6
Compare
I think I've figured out what to do with the old certificate type - I think it should go into the This also gave me a lead as to what is expected to be stubbed, so I managed to fix the tests. @joshdholtz I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you for fixing this 😊 This will go out today 💪
Hey @igor-makarov 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.204.3 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Resolves #19878