Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pem][spaceship] update development push certificate type ID #19879

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

igor-makarov
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #19878

@igor-makarov
Copy link
Contributor Author

@joshdholtz now I'm really out of my depth with all the build failures here.

But it does look like Apple changed the type ID.

@JimDabell
Copy link

Just a word of warning – AWS SNS is currently rejecting certificates created this way with:

Error creating SNS platform application: InvalidParameter: Invalid parameter: Attributes Reason: You provided a certificate of type OTHER, which cannot be used to create an application of type iOS Development. Please select an application of type OTHER or provide a certificate of type iOS Development

@Robotex
Copy link

Robotex commented Feb 1, 2022

now I'm really out of my depth with all the build failures here.

Build fail most likely because you didn't update the specs @
spaceship/spec/launcher_spec.rb#L128
spaceship/spec/portal/portal_stubbing.rb#L185
spaceship/spec/portal/portal_stubbing.rb#L200
spaceship/spec/portal/portal_client_spec.rb#L304

@nageshkumarmishra
Copy link

when we are planning to push the fix?

@valerio-castelli
Copy link
Contributor

I'd love to help, but I'm not sure I can push code to @igor-makarov's fork. If I can do so, I could take care of updating the specs.

@igor-makarov
Copy link
Contributor Author

The main question is whether we can just forget the old type ID - it's probably still going to appear for old certificates.

@igor-makarov
Copy link
Contributor Author

I think I've figured out what to do with the old certificate type - I think it should go into the OLDER_IOS_CERTIFICATE_TYPES box. The old ProductionPush is there.

This also gave me a lead as to what is expected to be stubbed, so I managed to fix the tests.

@joshdholtz I think this is ready for review.

@joshdholtz joshdholtz changed the title Update development push certificate type ID [cert] update development push certificate type ID Feb 11, 2022
@joshdholtz joshdholtz changed the title [cert] update development push certificate type ID [pem][spaceship] update development push certificate type ID Feb 11, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for fixing this 😊 This will go out today 💪

@joshdholtz joshdholtz merged commit 66b49da into fastlane:master Feb 11, 2022
@fastlane-bot
Copy link

Hey @igor-makarov 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.204.3 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pem] [spaceship] New "Apple Sandbox Push Services" certificate type
7 participants