Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship][deliver][pilot] temporarily fix finding app by filtering bundle id locally #19900

Merged

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Feb 3, 2022

Motivation and Context

Fixes #19898
Fixes #19899

Description

There is an issue with how App Store Connect API is handling /v1/apps?filter[bundleId]= where the bundle identifier is greater than 25 characters.

This PR temporarily removes the filter on the API request and will filter locally (which is not great because it needs to fetch all the apps).

This PR WILL GET UNDONE at somepoint when the API is fixed .

Radar/Feedback

FB9876626

@joshdholtz joshdholtz changed the title [spaceship][deliver][pilot] temporarily fix finding app by filtering by bundle id locally [spaceship][deliver][pilot] temporarily fix finding app by filtering bundle id locally Feb 3, 2022
@joshdholtz joshdholtz merged commit f200f0f into master Feb 3, 2022
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.204.1 🚀

@r3pps
Copy link

r3pps commented Feb 3, 2022

For some reason I am unable to update:

rashidepps@Rashids-MacBook-Pro-2 fastlane % fastlane update_fastlane             
[✔] 🚀 
[23:32:03]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[23:32:04]: -----------------------------
[23:32:04]: --- Step: update_fastlane ---
[23:32:04]: -----------------------------
[23:32:04]: Looking for updates for fastlane...
[23:32:07]: Updating fastlane from 2.204.0 to 2.204.1... 🚀
[23:32:07]: $ brew upgrade fastlane
Warning: fastlane 2.204.0 already installed
[23:32:08]: Finished updating fastlane
[23:32:08]: fastlane.tools successfully updated! I will now restart myself... 😴
[✔] 🚀 
[23:32:09]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[23:32:10]: -----------------------------
[23:32:10]: --- Step: update_fastlane ---
[23:32:10]: -----------------------------

#######################################################################
# fastlane 2.204.1 is available. You are on 2.204.0.
# You should use the latest version.
# Please update using `fastlane update_fastlane`.
#######################################################################
# Run `gem cleanup` from time to time to speed up fastlane
#######################################################################

2.204.1 Temporary App Store Connect Fix
* [spaceship][deliver][pilot] temporarily fix finding app by filtering by bundle id locally (#19900) via Josh Holtz (@joshdholtz)

Please update using `fastlane update_fastlane````

It says update successful but then prompts to update again

@joshdholtz
Copy link
Member Author

Homebrew takes some time to update.

It will be soon after Homebrew/homebrew-core#94377 gets merged but it's out of my hands 🤷‍♂️ The homebrew team is usually pretty quick at getting these merged in though! ❤️

@lorderster
Copy link

lorderster commented Feb 3, 2022

For some reason I am unable to update:

rashidepps@Rashids-MacBook-Pro-2 fastlane % fastlane update_fastlane             
[✔] 🚀 
[23:32:03]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[23:32:04]: -----------------------------
[23:32:04]: --- Step: update_fastlane ---
[23:32:04]: -----------------------------
[23:32:04]: Looking for updates for fastlane...
[23:32:07]: Updating fastlane from 2.204.0 to 2.204.1... 🚀
[23:32:07]: $ brew upgrade fastlane
Warning: fastlane 2.204.0 already installed
[23:32:08]: Finished updating fastlane
[23:32:08]: fastlane.tools successfully updated! I will now restart myself... 😴
[✔] 🚀 
[23:32:09]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[23:32:10]: -----------------------------
[23:32:10]: --- Step: update_fastlane ---
[23:32:10]: -----------------------------

#######################################################################
# fastlane 2.204.1 is available. You are on 2.204.0.
# You should use the latest version.
# Please update using `fastlane update_fastlane`.
#######################################################################
# Run `gem cleanup` from time to time to speed up fastlane
#######################################################################

2.204.1 Temporary App Store Connect Fix
* [spaceship][deliver][pilot] temporarily fix finding app by filtering by bundle id locally (#19900) via Josh Holtz (@joshdholtz)

Please update using `fastlane update_fastlane````

It says update successful but then prompts to update again

I was facing the same issue. I'm using bundle so I solved updating Fastlane via bundle.

joshdholtz added a commit that referenced this pull request Feb 3, 2022
…ltering by bundle id locally (#19900)"

This reverts commit f200f0f.
joshdholtz added a commit that referenced this pull request Feb 3, 2022
…ltering by bundle id locally (#19900)" (#19906)

This reverts commit f200f0f.
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.204.2 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 6, 2022
@lacostej lacostej deleted the joshdholtz-temporarily-filter-apps-by-bundle_id-locally branch November 24, 2023 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants