[Fastlane.Swift] Swift fastlane upgrader #18933 #19914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
After fixing #18933, some users report that an interactive message is always shown on execution.
I've verified that indeed the message appears, but it shouldn't.
This PR fixes that problem. After an upgrade, there must be no more messages asking to upgrade the project.
Description
Fix upgrade checks.
After an upgrade, there must be no messages asking to upgrade the project.
I've a simple fastlane test project.
There I run
bundle exec fastlane custom --verbose
and that runs the code to fix/test.I've checked different statuses of FastlaneSwiftRunner.xcodeproj: not including checked flags or not including FastlaneRunnerCopySigned build phase. It consists merely on run a first upgrade with the above mentioned command, and then discard flags or build phase related diffs and re run the command.
Testing Steps
clone fastlane test project
Run
bundle exec fastlane custom --verbose
. Check that message "Should we try to upgrade just your FastlaneSwiftRunner project? (y/n)" appears.Re run
bundle exec fastlane custom --verbose
. Check that message does not appear again.