Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastlane.Swift] Swift fastlane upgrader #18933 #19914

Merged

Conversation

kikeenrique
Copy link
Contributor

@kikeenrique kikeenrique commented Feb 4, 2022

  • fix upgrades checks to avoid false not up-to-date messages.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

After fixing #18933, some users report that an interactive message is always shown on execution.
I've verified that indeed the message appears, but it shouldn't.
This PR fixes that problem. After an upgrade, there must be no more messages asking to upgrade the project.

Description

Fix upgrade checks.
After an upgrade, there must be no messages asking to upgrade the project.

I've a simple fastlane test project.
There I run bundle exec fastlane custom --verbose and that runs the code to fix/test.

I've checked different statuses of FastlaneSwiftRunner.xcodeproj: not including checked flags or not including FastlaneRunnerCopySigned build phase. It consists merely on run a first upgrade with the above mentioned command, and then discard flags or build phase related diffs and re run the command.

Testing Steps

  • clone fastlane test project

  • Run bundle exec fastlane custom --verbose. Check that message "Should we try to upgrade just your FastlaneSwiftRunner project? (y/n)" appears.

  • Re run bundle exec fastlane custom --verbose. Check that message does not appear again.

+ fix upgrades checks to avoid false not up-to-date messages.
Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this! 🙌

@joshdholtz joshdholtz merged commit 2a77737 into fastlane:master Feb 11, 2022
@fastlane-bot
Copy link

Hey @kikeenrique 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.204.3 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants