Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom s3 endpoint for Match storage #19929

Closed
wants to merge 1 commit into from
Closed

Support custom s3 endpoint for Match storage #19929

wants to merge 1 commit into from

Conversation

mattblaq
Copy link

@mattblaq mattblaq commented Feb 8, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Our company no longer exposes git repos (where we were storing mobile certs) to BitRise (where we are running match from). We can, however, store certs on our own instance of Minio, an open source S3, and expose it to BitRise.

Description

This PR adds fastlane match options to support custom S3 endpoints.

Testing Steps

Setup a local Minio server

brew install minio/stable/minio
minio server ~/minio_test_data

Create Minio bucket

brew install minio/stable/mc
mc alias set minio_test http://127.0.0.1:9000 minioadmin minioadmin
mc mb minio_test/mobile-certs

Configure a Matchfile like this:

storage_mode "s3"
s3_endpoint "http://127.0.0.1:9000" # new
s3_access_key "minioadmin"
s3_secret_access_key "minioadmin"
s3_bucket "mobile-certs"
s3_region "us-west-1"
s3_ssl_verify_peer false # new
s3_force_path_style true # new

Run match

bundle exec fastlane match

Check for files with mc ls:

mc ls minio_test/mobile-certs

@mattblaq mattblaq closed this Feb 8, 2022
@mattblaq mattblaq deleted the match-support-minio branch February 8, 2022 15:39
@fastlane fastlane locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant