[Fastlane.Swift] readPodspec: return map of [String: Any] #19953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔑
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes a force-cast crash when using
readPodspec
.This is because a podspec can't typically be expressed as just a dictionary of
[String: String]
.Description
Changing the return type uses an overload of
parseDictionary
which doesn't force-cast the return value to[String: String]
, which causes a crash.This is technically a breaking API change to anyone using
readPodspec
but I struggle to see how any non-trivial Podspec would have successfully parsed as[String: String]
.Testing Steps
Using
readPodspec
shouldn't crash, and return a successful[String: Any]
.