Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship][tunes] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass #20088

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

nomunomu0504
Copy link
Contributor

@nomunomu0504 nomunomu0504 commented Mar 18, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #20086
Resolves #20085

Description

The reference index key for the TEAMS array was specifying a non-existent key, so the reference method to the TEAMS array has been corrected.

Testing Steps

We have confirmed that the following method works correctly after the modification.
Test your local fastlane code base with your setup

@nomunomu0504 nomunomu0504 changed the title [spaceship] fix undefined method `[]' of teams [spaceship] fix block in select_team': [!] undefined method []' for nil:NilClass` Mar 18, 2022
@nomunomu0504 nomunomu0504 changed the title [spaceship] fix block in select_team': [!] undefined method []' for nil:NilClass` [spaceship] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass Mar 18, 2022
@nomunomu0504 nomunomu0504 changed the title [spaceship] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass [spaceship][tunes] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass Mar 18, 2022
@nomunomu0504
Copy link
Contributor Author

nomunomu0504 commented Mar 18, 2022

Resolves #20086

@mjovkovic
Copy link
Contributor

@joshdholtz any timing for releasing this?

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the correctness of these changes, but this branch resolve the problem for me! Tested, approved ✅

Kindly tagging @joshdholtz here to check this PR code-wise 😉

@jterhorst
Copy link

jterhorst commented Mar 23, 2022

We were also encountering this error. It appeared to be because we have multiple teams on the account affected. We were able to workaround by including FASTLANE_ITC_TEAM_NAME when invoking the Fastlane command.

@rserentill
Copy link

@jterhorst this is only a workaround, as per the documentation, select_team function should show a list of available teams if none is provided, but instead it's crashing.

@rogerluan
Copy link
Member

FWIW, if it helps, during my tests, Appfile did explicitly contain both Team ID and name, and it was crashing regardless.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah! I can't believe I missed this one 😱 My apologies! This looks good to me and I really appreciate the fix ❤️

I'll get this out tonight yet

@joshdholtz joshdholtz merged commit abd1063 into fastlane:master Mar 24, 2022
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.205.1 🚀

@jonas-simkus-mw
Copy link

We are still encountering same error, this does not seem to be fixed yet. We can not produce any builds, neither with latest version nor the earlier versions of fastlane.

@AdamGerthel
Copy link

AdamGerthel commented Apr 13, 2022

Same here (using 2.205.1), crashing on "update_project_provisioning" with:

NoMethodError: [!] undefined method `[]' for nil:NilClass

            build_configuration.build_settings["PROVISIONING_PROFILE"] = data["UUID"]

UPDATE: Nevermind the above. Found the problem: #20172

@anutting
Copy link

I am still crashing with that above error. The workaround in that issue to swap to update_code_signing_settings does not work for me. I pass a .mobileprovision file (generated by sigh) into update_project_provisioning. Why did this function suddenly disappear without notice?

@rserentill
Copy link

There's a chance this is not related to fastlane, but to your provisioning profile, since Apple updated its WWDR certificates. Check this post: https://stackoverflow.com/questions/71850186/invalid-provisioning-profile-signature-state-error-validation-error-90165

@M7sn1982
Copy link

@fastlane-bot Delete

@fastlane fastlane locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet