-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship][tunes] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass #20088
[spaceship][tunes] fix 'block in select_team': [!] undefined method `[]' for nil:NilClass #20088
Conversation
block in select_team': [!] undefined method
[]' for nil:NilClass`
block in select_team': [!] undefined method
[]' for nil:NilClass`
Resolves #20086 |
@joshdholtz any timing for releasing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about the correctness of these changes, but this branch resolve the problem for me! Tested, approved ✅
Kindly tagging @joshdholtz here to check this PR code-wise 😉
We were also encountering this error. It appeared to be because we have multiple teams on the account affected. We were able to workaround by including |
@jterhorst this is only a workaround, as per the documentation, |
FWIW, if it helps, during my tests, Appfile did explicitly contain both Team ID and name, and it was crashing regardless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah! I can't believe I missed this one 😱 My apologies! This looks good to me and I really appreciate the fix ❤️
I'll get this out tonight yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.205.1 🚀
We are still encountering same error, this does not seem to be fixed yet. We can not produce any builds, neither with latest version nor the earlier versions of fastlane. |
Same here (using 2.205.1), crashing on "update_project_provisioning" with:
UPDATE: Nevermind the above. Found the problem: #20172 |
I am still crashing with that above error. The workaround in that issue to swap to update_code_signing_settings does not work for me. I pass a .mobileprovision file (generated by sigh) into update_project_provisioning. Why did this function suddenly disappear without notice? |
There's a chance this is not related to fastlane, but to your provisioning profile, since Apple updated its WWDR certificates. Check this post: https://stackoverflow.com/questions/71850186/invalid-provisioning-profile-signature-state-error-validation-error-90165 |
@fastlane-bot Delete |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Resolves #20086
Resolves #20085
Description
The reference index key for the TEAMS array was specifying a non-existent key, so the reference method to the TEAMS array has been corrected.
Testing Steps
We have confirmed that the following method works correctly after the modification.
Test your local fastlane code base with your setup