[scan] fix scan failing to return results when there are test failures #20237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using test_failure! method it causes scan to skip sending the output even if
fail_build
is set to falseChecklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Resolves #20236
Description
fail_build
option is set to false, it still causes the results to not be sent to consumers.fail_build
definition fromrun_tests
toscan
and then used the value offail_build
to determine whether to raise the exception or to just post a ui error.Testing Steps
Added a unit test to confirm that with
fail_build
set to false it returns the output from the action and that the output contains the correct values.