Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/import from git spec fail with non master default branch #20297

Conversation

lacostej
Copy link
Collaborator

On my computer, tests are failing as my default git branch is main.

@lacostej lacostej requested a review from revolter May 18, 2022 17:25
@lacostej
Copy link
Collaborator Author

Looks like not everything is stable on the other platforms. I'll keep the master branch name for now.

@lacostej lacostej force-pushed the fix/import_from_git_spec_fail_with_non_master_default_branch branch from 34f8320 to b9769ab Compare May 18, 2022 19:14
Copy link
Collaborator

@revolter revolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 💪🏻

@lacostej lacostej merged commit 4b5dd66 into fastlane:master May 19, 2022
@lacostej lacostej deleted the fix/import_from_git_spec_fail_with_non_master_default_branch branch May 19, 2022 11:54
@fastlane-bot
Copy link

Hey @lacostej 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.206.1 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants