[match] add profile_type filtering when checking if profile exists #20311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulTaykalo
commented
May 22, 2022
PaulTaykalo
force-pushed
the
fix/add-filter-for-match
branch
from
86c6c90
to
fa23628
Compare
lucgrabowski
requested changes
May 24, 2022
joshdholtz
requested changes
May 25, 2022
match/lib/match/spaceship_ensure.rb
Outdated
Comment on lines
80
to
82
| # But we can filter provisioning profiles based on their type (this, in general way faster than getting all profiles) | ||
| filter = { profileType: profile_types(type).join(",") } if type | ||
| found = Spaceship::ConnectAPI::Profile.all(filter: filter).find do |profile| |
There was a problem hiding this comment.
This is so smart! Slightly embarrassed I didn't do this right away 🙈
PaulTaykalo
force-pushed
the
fix/add-filter-for-match
branch
3 times, most recently
from
d25b4c2
to
7d683b2
Compare
PaulTaykalo
commented
May 26, 2022
| types = profile_types(prov_type) | ||
| # Filtering on 'profileType' seems to be undocumented as of 2020-07-30 | ||
| # but works on both web session and official API | ||
| types = Match.profile_types(prov_type) |
There was a problem hiding this comment.
Same here. this information is actually mentioned in documentation at this moment (2022-05-22)
https://developer.apple.com/documentation/appstoreconnectapi/list_and_download_profiles#query-parameters
lucgrabowski
approved these changes
May 26, 2022
|
@joshdholtz Is there anything needed to be added? |
|
bump |
joshdholtz
force-pushed
the
fix/add-filter-for-match
branch
from
7d683b2
to
6a4d9a8
Compare
joshdholtz
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
When
matchchecking if profile exists on AppStore Connect, the check is relatively slow, if performed without filtering.App Store Connect API doesn't support filtering by the profile
uuid, but it supports filtering byprofileType.Adding filtering by
profileTypesignificantly speeds up requests, thatmatchis performinghttps://developer.apple.com/documentation/appstoreconnectapi/list_and_download_profiles#query-parameters
It seems that response time highly depends on the amount of returned items.
It was around ~20s for 85 profiles, and ~4s for 9 profiles (with filtering).
Description
Additional filtering is added by
profileTypeTesting Steps