Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the architecture to run xcodebuild under #20323

Merged
merged 1 commit into from
May 27, 2022

Conversation

milch
Copy link
Collaborator

@milch milch commented May 25, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary. (N/A)

Motivation and Context

This allows users to set explicitly what architecture to run xcodebuild as. For example, fastlane might be running under Rosetta, but xcodebuild should be running natively, or fastlane might be running natively but xcodebuild should be running under Rosetta.

Description

With a simple test app:

fastlane run xcodebuild scheme:Test project:Test.xcodeproj xcodebuild_architecture:x86_64 destination:"platform=iOS Simulator,name=iPhone 11"
[βœ”] πŸš€
[13:32:19]: ------------------------
[13:32:19]: --- Step: xcodebuild ---
[13:32:19]: ------------------------
[13:32:19]: For a more detailed xcodebuild log open /Users/wallman/Library/Logs/fastlane/xcbuild/2022-05-25/67935/xcodebuild.log
[13:32:19]: $ set -o pipefail && arch -x86_64 xcodebuild -scheme "Test" -project "Test.xcodeproj" -destination "platform=iOS Simulator,name=iPhone 11" | tee '/Users/wallman/Library/Logs/fastlane/xcbuild/2022-05-25/67935/xcodebuild.log' | xcpretty --color --simple
[13:32:21]: β–Έ Build Succeeded
β–Έ Build Succeeded

Testing Steps

N/A

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@milch milch merged commit c02fa82 into fastlane:master May 27, 2022
@milch milch deleted the override-xcodebuild-arch branch May 27, 2022 18:31
@fastlane-bot
Copy link

Hey @milch πŸ‘‹

Thank you for your contribution to fastlane and congrats on getting this pull request merged πŸŽ‰
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here πŸ‘
We'll notify you once we shipped a new release with your changes πŸš€

@fastlane-bot
Copy link

Congratulations! πŸŽ‰ This was released as part of fastlane 2.207.0 πŸš€

@fastlane fastlane locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants