-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] add imports, fix linting errors, rename env variable #20418
Conversation
api_v4_url: 'https://gitlab.example.com/api/v4', | ||
project_id: 'sample/project', | ||
private_token: 'abc123' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one be indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably should 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn't make CI angry and I don't feel like waiting for CI to run again tonight so I'll let that one slide for now 😉
@@ -20,7 +24,7 @@ def create_subfolders(working_directory) | |||
def destination_file_path | |||
filename = @file.name.split('/').last | |||
|
|||
@file.name.gsub(filename, '').gsub(/^\//, '') | |||
@file.name.gsub(filename, '').gsub(%r{^/}, '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey @joshdholtz 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀 |
Motivation and Context
Cleanup from #20386 where some CI jobs didn't run lint errors weren't caught
Description
GITLAB_PROJECT
toMATCH_GITLAB_PROJECT