-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match][sigh][cert] Added checking hash of installed wwdr certificates #20507
Conversation
@getaaron I've created PR, could your review this? |
@grey442 code looks good! could you please login to circleci using github oauth and rerun the build (either in circleCI, or push a blank commit)? the circle builds didn't run on your PR https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- |
@grey442 friendly bump on the CI tests :) |
@getaaron ouch, I have some problem with CircleCI. My Github account was blocked in CircleCI and I will restore access only after few months. Is there another way to run the build? :) |
hmm let me try pushing a commit in |
Hey @grey442 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.209.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
On different machines can be installed different wwdr certificates, but that certificates have same name "Apple Worldwide Developer Relations Certification Authority"
And It can be a problem in case:
On "new machine" fastlane will install the latest wwdr certificate https://www.apple.com/certificateauthority/AppleWWDRCAG6.cer
On "old machine" fastlane wouldn't install the latest wwdr certificate if other wwdr certificate exists
If provision profiles was created "old machine" than code sign on "old machine" will be successful, but on "new machine" code sign will be failed
Description
man security> find-certificate -a -c MyName -Z login.keychain | grep ^SHA-256
SHA-256 hash: BDD4ED6E74691F0C2BFD01BE0296197AF1379E0418E2D300EFA9C3BEF642CA30
of certificate https://www.apple.com/certificateauthority/AppleWWDRCAG6.cerTesting Steps
--verbose
lane wherematch
install provision profiles and certificatesfastlane
install the latest wwdr certificate https://www.apple.com/certificateauthority/AppleWWDRCAG6.cer