-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] add xcodes
action, deprecating xcversion
and xcode-install
#20672
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7c1de15 - Browse repository at this point
Copy the full SHA 7c1de15View commit details -
Deprecate 'xcode-install' gem (the project has been sunset), adding '…
…xcodes' action to replace the 'xcode_install' one.
Configuration menu - View commit details
-
Copy full SHA for 676e3ee - Browse repository at this point
Copy the full SHA 676e3eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c5c733 - Browse repository at this point
Copy the full SHA 8c5c733View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb583d5 - Browse repository at this point
Copy the full SHA eb583d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54786b0 - Browse repository at this point
Copy the full SHA 54786b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8d6090 - Browse repository at this point
Copy the full SHA b8d6090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 766c53b - Browse repository at this point
Copy the full SHA 766c53bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d6ff1f - Browse repository at this point
Copy the full SHA 6d6ff1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9670be - Browse repository at this point
Copy the full SHA c9670beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97dff12 - Browse repository at this point
Copy the full SHA 97dff12View commit details -
Add ability to select Xcode just for current build, without sudo perm…
…issions. - Depends on XcodesOrg/xcodes#220
Configuration menu - View commit details
-
Copy full SHA for c1c32ee - Browse repository at this point
Copy the full SHA c1c32eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2dafb7 - Browse repository at this point
Copy the full SHA c2dafb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e84283 - Browse repository at this point
Copy the full SHA 7e84283View commit details -
Apply suggestions from code review.
Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5675137 - Browse repository at this point
Copy the full SHA 5675137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b5d083 - Browse repository at this point
Copy the full SHA 4b5d083View commit details -
Configuration menu - View commit details
-
Copy full SHA for 083af9f - Browse repository at this point
Copy the full SHA 083af9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f9b24e - Browse repository at this point
Copy the full SHA 5f9b24eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b33e8 - Browse repository at this point
Copy the full SHA 23b33e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d66a490 - Browse repository at this point
Copy the full SHA d66a490View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc0824 - Browse repository at this point
Copy the full SHA 9fc0824View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccf5ec6 - Browse repository at this point
Copy the full SHA ccf5ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 594d707 - Browse repository at this point
Copy the full SHA 594d707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30cd166 - Browse repository at this point
Copy the full SHA 30cd166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 136b664 - Browse repository at this point
Copy the full SHA 136b664View commit details -
Remove superfluous trailing slash
This makes it consistent with the rest of the codebase.
Configuration menu - View commit details
-
Copy full SHA for 7d0caea - Browse repository at this point
Copy the full SHA 7d0caeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 317296b - Browse repository at this point
Copy the full SHA 317296bView commit details -
Fix some WWDR certificates test failure
This was caused by the fact that that test calls a method that uses `$?` (https://stackoverflow.com/a/6834572/865175), which, somehow, (I think) was executed right after a call to XcodesHelper's `find_xcodes_binary_path` method. This latter one returned a non-zero code, because `xcodes` can't be installed on Ubuntu, which got picked up by the certificates return code check, so it treated its actual command as failed.
Configuration menu - View commit details
-
Copy full SHA for 11bd750 - Browse repository at this point
Copy the full SHA 11bd750View commit details
Commits on Nov 3, 2022
-
Replace
Actions.sh
call with a native one(reverted from commit 11bd750)
Configuration menu - View commit details
-
Copy full SHA for 1a27157 - Browse repository at this point
Copy the full SHA 1a27157View commit details
Commits on Nov 4, 2022
-
Fix error-prone shell command status check
In the case of the tests, `$?` was not mocked, so it looks like it was indeed just a coincidence that it worked. Meaning, some other shell command that somehow was actually executed (so it wasn't stubbed) succeeded, which caused the `$?.success?` to succeed too.
Configuration menu - View commit details
-
Copy full SHA for 58a0ed9 - Browse repository at this point
Copy the full SHA 58a0ed9View commit details