-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] implement resolution center API in Spaceship::ConnectAPI #20726
[spaceship] implement resolution center API in Spaceship::ConnectAPI #20726
Conversation
@Hiroto-N I added another method to your pr. I opened a pr on your repro Hiroto-N#1. |
@joshdholtz It would be great if this could get merged, it provides apis and models to traverse the updated resolution center. |
Aye aye! Will get merged and released tonight 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Sorry about just getting to this 🤦 Trying to get used to the new lifestyle and time balance.
I added a commit that adds a comment about this API only being available via Apple ID auth but other than that this is 🔥
Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Old resolution center code is implemented in the old Spaceship::Tunes endpoints, which sometimes does not return the expected messages properly due to some recent changes in appstore connect. The new calls are being made using the same endpoint as the rest of the Appstore Connect APIs, which have been implemented here following the standard format in spaceship.
Description
Previous implementation for retrieving resolution center comments for appstore and beta submissions were using the old private api endpoint https://appstoreconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/:app_id/platforms/ios/resolutionCenter?v=latest
New implementation is based on sniffing the traffic in Appstore Connect, which now uses the Appstore Connect APIs, although they have not been published in the API documentation yet and is not accessible using the api key.
e.g. base endpoint for threads is https://appstoreconnect.apple.com/iris/v1/resolutionCenterThreads
Testing Steps