Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports #21225

Closed
wants to merge 3 commits into from
Closed

[snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports #21225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
797201d
Add missing newer iPhone models to Generated Snapshot Reports
kylehowells Apr 22, 2023
2f086fb
Add missing iPad versions as well
kylehowells Apr 22, 2023
f85e84a
Fix accidental duplicate
kylehowells Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions snapshot/lib/snapshot/reports_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ def xcode_9_and_above_device_name_mappings
{
# snapshot in Xcode 9 saves screenshots with the SIMULATOR_DEVICE_NAME
# which includes spaces
'iPhone 14 Pro Max' => "iPhone 14 Pro Max",
'iPhone 14 Pro' => "iPhone 14 Pro",
'iPhone 14 Plus' => "iPhone 14 Plus",
'iPhone 14' => "iPhone 14",
'iPhone SE (3rd generation)' => "iPhone SE (3rd generation)",
'iPhone 13 Pro Max' => "iPhone 13 Pro Max",
'iPhone 13 Pro' => "iPhone 13 Pro",
'iPhone 13 mini' => "iPhone 13 mini",
Expand All @@ -92,6 +97,7 @@ def xcode_9_and_above_device_name_mappings
'iPhone 12 Pro' => "iPhone 12 Pro",
'iPhone 12 mini' => "iPhone 12 mini",
'iPhone 12' => "iPhone 12",
'iPhone SE (2nd generation)' => "iPhone SE (2nd generation)",
'iPhone 11 Pro Max' => "iPhone 11 Pro Max",
'iPhone 11 Pro' => "iPhone 11 Pro",
'iPhone 11' => "iPhone 11",
Expand All @@ -112,20 +118,33 @@ def xcode_9_and_above_device_name_mappings
'iPhone SE' => "iPhone SE",
'iPhone 4s' => "iPhone 4s (3.5-Inch)",
'iPad 2' => 'iPad 2',
'iPad Air (5th generation)' => 'iPad Air (5th generation)',
'iPad Air (4th generation)' => 'iPad Air (4th generation)',
'iPad Air (3rd generation)' => 'iPad Air (3rd generation)',
'iPad Air 2' => 'iPad Air 2',
'iPad Air' => 'iPad Air',
'iPad (5th generation)' => 'iPad (5th generation)',
'iPad (7th generation)' => 'iPad (7th generation)',
'iPad (8th generation)' => 'iPad (8th generation)',
'iPad (9th generation)' => 'iPad (9th generation)',
'iPad (10th generation)' => 'iPad (10th generation)',
'iPad mini 2' => 'iPad mini 2',
'iPad mini 3' => 'iPad mini 3',
'iPad mini 4' => 'iPad mini 4',
'iPad mini (5th generation)' => 'iPad mini (5th generation)',
'iPad mini (6th generation)' => 'iPad mini (6th generation)',
'iPad Pro (9.7-inch)' => 'iPad Pro (9.7-inch)',
'iPad Pro (9.7 inch)' => 'iPad Pro (9.7-inch)', # iOS 10.3.1 simulator
'iPad Pro (10.5-inch)' => 'iPad Pro (10.5-inch)',
'iPad Pro (11-inch) (4th generation) (16GB)' => 'iPad Pro (11-inch) (4th generation) (16GB)',
'iPad Pro (11-inch) (4th generation)' => 'iPad Pro (11-inch) (4th generation)',
'iPad Pro (11-inch) (3rd generation)' => 'iPad Pro (11-inch) (3rd generation)',
'iPad Pro (11-inch) (2nd generation)' => 'iPad Pro (11-inch) (2nd generation)',
'iPad Pro (11-inch) (1st generation)' => 'iPad Pro (11-inch) (1st generation)',
'iPad Pro (11-inch)' => 'iPad Pro (11-inch)',
'iPad Pro (12.9-inch) (6th generation) (16GB)' => 'iPad Pro (12.9-inch) (6th generation) (16GB)',
'iPad Pro (12.9-inch) (6th generation)' => 'iPad Pro (12.9-inch) (6th generation)',
'iPad Pro (12.9-inch) (5th generation)' => 'iPad Pro (12.9-inch) (5th generation)',
'iPad Pro (12.9-inch) (4th generation)' => 'iPad Pro (12.9-inch) (4th generation)',
'iPad Pro (12.9-inch) (3rd generation)' => 'iPad Pro (12.9-inch) (3rd generation)',
'iPad Pro (12.9-inch) (2nd generation)' => 'iPad Pro (12.9-inch) (2nd generation)',
Expand Down