Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][sh] fix undefined sh_enabled? method when using Action.sh from a plugin Action #21408

Merged
merged 1 commit into from Apr 3, 2024

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Jul 18, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

When calling sh action from a plugin Action helper, I get an error undefined method ``sh_enabled?`` for Fastlane::Actions::Helper:Class (NoMethodError if Helper.sh_enabled?...

Description

Explicitly specify the full path to the FastlaneCore module when calling Helper.sh_enabled? method.

Testing Steps

🤷

…om a different module

fix error: undefined method `sh_enabled?' for Fastlane::Actions::Helper:Class (NoMethodError if Helper.sh_enabled?
Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucgrabowski lucgrabowski merged commit 1e517a9 into fastlane:master Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants