Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests][ci] clean up tests output on CI #21668

Merged
merged 14 commits into from Dec 4, 2023

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Nov 24, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

Still trying to get the test output to only display . or X in minified mode.

Remains

  • plenty of xcodebuild errors like this one
2023-11-24 19:18:08.713 xcodebuild[3270:11980] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore

Testing Steps

@lacostej
Copy link
Collaborator Author

Ready for review

Almost all errors are hidden on CI. Remains one issue, but it comes from Security::InternetPassword.

image

@lacostej lacostej changed the title Fix clean test output Clean test output on CI Nov 29, 2023
fastlane/lib/fastlane/actions/verify_build.rb Outdated Show resolved Hide resolved
fastlane/spec/cli_tools_distributor_spec.rb Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/helper.rb Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great changes to improve a bit of QoL for us 😁

Thank you!

@rogerluan rogerluan changed the title Clean test output on CI [tests][ci] clean up tests output on CI Dec 4, 2023
fastlane/spec/cli_tools_distributor_spec.rb Outdated Show resolved Hide resolved
@lacostej lacostej merged commit 55f4e7f into fastlane:master Dec 4, 2023
2 checks passed
@lacostej lacostej deleted the fix/clean_test_output branch December 4, 2023 17:54
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
* Rewrite changelog_from_git_commits_spec test that outputs to STDOUT

* Disable Helper.show_loading_indicator in test output

* Disable Helper.show_loading_indicator in test output

* Hide warnings and other errors into standard output, hidden during tests

* Prevent code from generating unecessary output in tests

* Remove WARNING from stdout.

* Fastlane::CLIToolsDistributor remove output from tests

* Disable output messages that pops up in newer git init setup

* hide the swift --version generated stderr output

* Take into account code review

* Move stdout/stderr hiding into command generation

* Improve the code that disables the UpdateChecker

* Cleanup unecessary .to_s

* Improve the test setup to avoid side effects with ENV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants