New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][ci] clean up tests output on CI #21668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
fix/clean_test_output
branch
4 times, most recently
from
November 29, 2023 08:14
f2d40d8
to
3fd0042
Compare
Ready for review Almost all errors are hidden on CI. Remains one issue, but it comes from Security::InternetPassword. |
5 tasks
AliSoftware
reviewed
Dec 1, 2023
lacostej
force-pushed
the
fix/clean_test_output
branch
from
December 4, 2023 09:27
4d011c0
to
43e355c
Compare
rogerluan
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great changes to improve a bit of QoL for us 😁
Thank you!
rogerluan
changed the title
Clean test output on CI
[tests][ci] clean up tests output on CI
Dec 4, 2023
AliSoftware
approved these changes
Dec 4, 2023
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
* Rewrite changelog_from_git_commits_spec test that outputs to STDOUT * Disable Helper.show_loading_indicator in test output * Disable Helper.show_loading_indicator in test output * Hide warnings and other errors into standard output, hidden during tests * Prevent code from generating unecessary output in tests * Remove WARNING from stdout. * Fastlane::CLIToolsDistributor remove output from tests * Disable output messages that pops up in newer git init setup * hide the swift --version generated stderr output * Take into account code review * Move stdout/stderr hiding into command generation * Improve the code that disables the UpdateChecker * Cleanup unecessary .to_s * Improve the test setup to avoid side effects with ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Still trying to get the test output to only display . or X in minified mode.
Remains
Testing Steps