Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] enforce latest available gem version and use the specific bundler version specified in the lock file #21805

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Jan 14, 2024

I extracted this old code from #20293. I used it to ensure a more consistent environment across builds.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Well now I remember why I did put that in #20293, the appveyor environment fails because we have a too old bundler on appveyor. So we should really merge this before we merge #20293...

Description

Testing Steps

@lacostej lacostej changed the title [ci] play with gem version [ci] use latest available gem for the given ruby and always use the specific bundler version specified in the lock file Jan 14, 2024
@lacostej lacostej changed the title [ci] use latest available gem for the given ruby and always use the specific bundler version specified in the lock file [ci] enforce latest available gem version and use the specific bundler version specified in the lock file Jan 14, 2024
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions 🙇

appveyor/bundler_version.rb Outdated Show resolved Hide resolved
.ci/compatible_gem_version Outdated Show resolved Hide resolved
.ci/compatible_gem_version Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@rogerluan rogerluan merged commit 204c892 into fastlane:master Jan 15, 2024
3 checks passed
@lacostej lacostej deleted the ci/gem_update branch January 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants