Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WARNINGs when building fastlane gemspec #21807

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Jan 15, 2024

Annoying warnings when building the gemspec. Clutters the logs and the mind.

$ gem build fastlane.gemspec
WARNING:  description and summary are identical
WARNING:  open-ended dependency on colored (>= 0) is not recommended
  use a bounded requirement, such as '~> x.y'
WARNING:  open-ended dependency on optparse (>= 0.1.1) is not recommended
  if optparse is semantically versioned, use:
    add_runtime_dependency 'optparse', '~> 0.1', '>= 0.1.1'
WARNING:  open-ended dependency on xcpretty-travis-formatter (>= 0.0.3) is not recommended
  if xcpretty-travis-formatter is semantically versioned, use:
    add_runtime_dependency 'xcpretty-travis-formatter', '~> 0.0', '>= 0.0.3'
WARNING:  See https://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: fastlane
  Version: 2.219.0
  File: fastlane-2.219.0.gem

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

  • tightened some dependencies
  • added a gem summary

Testing Steps

@@ -75,7 +75,7 @@ Gem::Specification.new do |spec|
spec.add_dependency('babosa', '>= 1.0.3', '< 2.0.0') # library for creating human-friendly identifiers, aka "slugs"
spec.add_dependency('bundler', '>= 1.12.0', '< 3.0.0') # Used for fastlane plugins
spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format
spec.add_dependency('colored') # colored terminal output
spec.add_dependency('colored', '~> 1.2') # colored terminal output
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version was released in 2010. So pretty safe even though in theory bumping could still be a problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine

fastlane.gemspec Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -75,7 +75,7 @@ Gem::Specification.new do |spec|
spec.add_dependency('babosa', '>= 1.0.3', '< 2.0.0') # library for creating human-friendly identifiers, aka "slugs"
spec.add_dependency('bundler', '>= 1.12.0', '< 3.0.0') # Used for fastlane plugins
spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format
spec.add_dependency('colored') # colored terminal output
spec.add_dependency('colored', '~> 1.2') # colored terminal output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine

@lacostej lacostej merged commit 4e95dfd into fastlane:master Jan 15, 2024
3 checks passed
@lacostej lacostej deleted the fix/gem_spec_warnings branch January 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants