-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WARNINGs when building fastlane gemspec #21807
Conversation
@@ -75,7 +75,7 @@ Gem::Specification.new do |spec| | |||
spec.add_dependency('babosa', '>= 1.0.3', '< 2.0.0') # library for creating human-friendly identifiers, aka "slugs" | |||
spec.add_dependency('bundler', '>= 1.12.0', '< 3.0.0') # Used for fastlane plugins | |||
spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format | |||
spec.add_dependency('colored') # colored terminal output | |||
spec.add_dependency('colored', '~> 1.2') # colored terminal output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version was released in 2010. So pretty safe even though in theory bumping could still be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -75,7 +75,7 @@ Gem::Specification.new do |spec| | |||
spec.add_dependency('babosa', '>= 1.0.3', '< 2.0.0') # library for creating human-friendly identifiers, aka "slugs" | |||
spec.add_dependency('bundler', '>= 1.12.0', '< 3.0.0') # Used for fastlane plugins | |||
spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format | |||
spec.add_dependency('colored') # colored terminal output | |||
spec.add_dependency('colored', '~> 1.2') # colored terminal output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine
Annoying warnings when building the gemspec. Clutters the logs and the mind.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps