[deliver] Initialize UploadMetadata with options #21861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lacostej
approved these changes
Feb 9, 2024
lacostej
merged commit 064f5c1
into
rogerluan/add-exponential-backoff-to-retry
3 checks passed
lacostej
pushed a commit
that referenced
this pull request
Feb 9, 2024
… even when Apple servers are degraded (#21742) * Add exponential backoff to retry mechanism that checks for app version existence. * Add option for users to increase the number of max retries if needed. * Fix linter issue complaining about long line. * Set max wait time to 5 minutes. * Adjust default number of retries to a more sensible number. * [deliver] Initialize UploadMetadata with options (#21861) * [deliver] Initialize UploadMetadata with options * Fix linting --------- Co-authored-by: Daniel Jankowski <daniell.jankowskii@gmail.com>
rogerluan
reviewed
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This pull request addresses the requested changes in here: #21742 (comment)
Please note this pull request is going to be merged into parent branch, not a
mainbranch.Description
To avoid redundant parameters setting and passing around, the
UploadMetadatais not initialized withoptions.Testing Steps
CI Pipelines ✔️