Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] Include visionOS devices in provisioning profiles #21871

Merged

Conversation

peter-gyarmati
Copy link
Contributor

@peter-gyarmati peter-gyarmati commented Feb 14, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

See #21860 for more context.

Description

Added APPLE_VISION_PRO to the DeviceClass enum in order to include Vision Pro devices in iOS provisioning profiles.
Also added VISION_OS to SpaceShip to support the platform in AppStore connect.

Testing Steps

Generated new provisioning profiles and validated that the devices are present in the iOS provisioning profiles.

Did it with the following steps:

profile=$(security cms -D -i <PATH-TO_PROFILE>)
echo $profile | grep "<DEVICE_UDID>"

This should return successfully if the device is present in the profile.

@peter-gyarmati
Copy link
Contributor Author

@rogerluan @lacostej Could you please take a look at this PR? I'd like to get it merged before the next release. (When is the next release?)

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing I wonder is that if I understand correctly, Apple has renamed xros into visionos at the last minute.

We just introduced the public parameter for pilot in #21841, and I wonder if we should have named it visionos instead.

@peter-gyarmati
Copy link
Contributor Author

peter-gyarmati commented Feb 17, 2024

LGTM.

One thing I wonder is that if I understand correctly, Apple has renamed xros into visionos at the last minute.

We just introduced the public parameter for pilot in #21841, and I wonder if we should have named it visionos instead.

I think they didn't decide on the naming yet, that's why I went with both options. Actually if you unpack a provisioning profile, the platform part looks like this:

<key>Platform</key>
	<array>
		<string>iOS</string>
		<string>xrOS</string>
		<string>visionOS</string>
	</array> 

IMHO the most sustainable way would be supporting both until Apple decides on one or the other. (However my hunch is that both will stay in different circumstances)

P.s. If you could merge it, I would be grateful.

@peter-gyarmati
Copy link
Contributor Author

Could someone please merge this? @lacostej @rogerluan

@lucgrabowski lucgrabowski merged commit d8aa8fc into fastlane:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants