Workaround for correctly exporting IPA when generic archive Xcodebuild bug occurs #4066
Conversation
jcampbell05
changed the title
jcampbell05
changed the title
|
@jcampbell05 what is your sense of how wide spread of a problem this is? Are others seeing the issue too and just not reporting it? Should we put an opt-in mechanism for this? I just don't want to break a workflow for someone that needs it to work this way currently. |
| @@ -58,6 +60,7 @@ def ipa_path | |||
| ErrorHandler.handle_empty_archive unless path | |||
| end | |||
| end | |||
|
|
|||
|
|
||
| # Does this application have a WatchKit target | ||
| def is_watchkit_ipa?(plist_path) | ||
| `/usr/libexec/PlistBuddy -c 'Print DTSDKName' '#{plist_path}' 2>&1`.match(/^\s*watchos2\.\d+\s*$/) != nil |
There was a problem hiding this comment.
For getting the path into the command, do #{plist_path.shellescape} without the quotes 👍
There was a problem hiding this comment.
@mfurtak I'll update this but we should think about having utility commands for these things in another PR, this is used elsewhere without shellescape unfortunately :(
|
@samrobbins This is a pretty wide-spread problem based on the issue filed with CocoaPods CocoaPods/CocoaPods#4178. They may not have reported it since potentially it could be something wrong with their project triggering a bug with Xcode and CocoaPods (so not technically a Fastlane issue) but currently there isn't a straight forward reason to why this bug occurs (But I am working with CocoaPods to identify this, so either we or Apple can fix it). That said, I am not against putting some sort of flag for now to switch this fix on or off depending on your needs if people need to archive the watch app itself. The only reason we may not need this flag, is the only useful way to use a watch app archive is inside of a iOS App so potentially this use case is small and most developers would just archive the iOS App. |
|
@jcampbell05 I have reservations about the assumptions we are making with regard to identifying a project as iOS, tvOS etc. But after I asked the question I thought about it some more and perhaps having things work a certain way vs needing to know extra flags is better. @mfurtak thoughts on this last statement? |
|
|
| @@ -72,6 +73,11 @@ def clear_old_files | |||
| end | |||
| end | |||
|
|
|||
| def fix_archive | |||
| return unless Gym.config[:use_legacy_build_api] | |||
There was a problem hiding this comment.
Let's do as @samrobbins suggests and put this behavior behind a feature switch for now.
Something like:
return unless Gym.config[:use_legacy_build_api] && !ENV['FASTLANE_GYM_USE_GENERIC_ARCHIVE_FIX'].nil?
There was a problem hiding this comment.
This is confusing, with a lot of !, unless and nil?. Could we split it up to multiple lines?
There was a problem hiding this comment.
| end | ||
| end | ||
|
|
||
|
|
|
Updated and all the raised issues resolved. |
| @@ -103,6 +103,16 @@ def self.plain_options | |||
| UI.important "Using legacy build system - waiting for radar to be fixed: https://openradar.appspot.com/radar?id=4952000420642816" | |||
| end | |||
| end), | |||
| FastlaneCore::ConfigItem.new(key: :use_generic_archive_fix, | |||
There was a problem hiding this comment.
Align the elements of an array literal if they span more than one line.
| @@ -103,6 +103,16 @@ def self.plain_options | |||
| UI.important "Using legacy build system - waiting for radar to be fixed: https://openradar.appspot.com/radar?id=4952000420642816" | |||
| end | |||
| end), | |||
| FastlaneCore::ConfigItem.new(key: :use_generic_archive_fix, | |||
| env_name: "GYM_USE_GENERIC_ARCHIVE_FIX", | |||
| description: "Use fix for generic arhives https://github.com/CocoaPods/CocoaPods/issues/4178", | |||
There was a problem hiding this comment.
There is a spelling mistake arhives, could you submit a PR fixing it, or was it already fixed?
Workaround for CocoaPods/CocoaPods#4178
In certain project configurations Xcodebuild creates a generic archive with the iOS App with Apple Watch App and the Apple Watch app in the products folder.
This is a small tweak to remove any Watch IPAs in the root of the archive (i.e not inside of a iOS App) since in pretty much all cases a developer wouldn't want / need this.
Hopefully this will increase the chances that
gymwill pick the correct IPA file when this bug occurs.