Add rubocop to plugin template

[neonichu]

• Adds symlink to shared .rubocop.yml
• Add rake and rubocop as development dependencies
• Add rspec and rubocop rake tasks
• Fix rubocop issues in the template

cc @KrauseFx

[fastlane-danger-bot]

      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del><code>fastlane/spec/plugins_specs/plugin_generator_spec.rb:200</code><hr /><pre>expected collection contained:  [<Gem::Dependency type=:development name="bundler" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="fastlane" requirements=">= 1.93.0&quot;&gt;, <Gem::Dependency type=:development name="pry" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="rspec" requirements=">= 0&quot;&gt;]<br />actual collection contained:    [<Gem::Dependency type=:development name="bundler" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="fastlane" requirements=">= 1.93.0&quot;&gt;, <Gem::Dependency type=:development name="pry" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="rake" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="rspec" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="rubocop" requirements=">= 0&quot;&gt;]<br />the extra elements were:        [<Gem::Dependency type=:development name="rake" requirements=">= 0&quot;&gt;, <Gem::Dependency type=:development name="rubocop" requirements=">= 0&quot;&gt;]</pre></del></td>
  </tr>
      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del><code>fastlane/spec/plugins_specs/plugin_generator_spec.rb:270</code><hr /><pre>expected: &quot;require &#39;bundler/gem_tasks&#39;<br />&quot;<br />     got: &quot;require &#39;bundler/gem_tasks&#39;<br /><br />require &#39;rspec/core/rake_task&#39;<br />RSpec::Core::RakeTask.new<br /><br />require &#39;rubocop/rake_task&#39;<br />RuboCop::RakeTask.new(:rubocop)<br /><br />task default: [:spec, :rubocop]<br />&quot;<br />(compared using ==)<br />Diff:�[0m<br />�[0m�[34m@@ -1,2 +1,10 @@<br />�[0m�[0m require &#39;bundler/gem_tasks&#39;<br />�[0m�[32m+<br />�[0m�[32m+require &#39;rspec/core/rake_task&#39;<br />�[0m�[32m+RSpec::Core::RakeTask.new<br />�[0m�[32m+<br />�[0m�[32m+require &#39;rubocop/rake_task&#39;<br />�[0m�[32m+RuboCop::RakeTask.new(:rubocop)<br />�[0m�[32m+<br />�[0m�[32m+task default: [:spec, :rubocop]<br />�[0m</pre></del></td>
  </tr>

	:white_check_mark: Woo! </th> </tr>

	1 Warning </th> </tr>
⚠️	Before submitting a Pull Request, please create an issue on GitHub to discuss the change. Please add a link to the issue in the PR body.

Generated by 🚫 danger

[KrauseFx]

That doesn't seem right? Does that require the fastlane main repo to be in that directory?

[neonichu]

Good point, this won't work when the gem is actually installed, only when using it via :path from the #monorepo. I wanted to avoid duplicating that file — any good ideas?

[KrauseFx]

I'd say we copy over the .rubocop.yml, because if fastlane changes the design guidelines, we don't want it to break plugins. I'll also try to reduce the amount of custom rules in there now 👍

[KrauseFx]

Alright, I reduced the size of the .rubocop.yml, please copy the file. It might be that it's not bundled with the actual gem, so you might need to update fastlane.gemspec (which might not allow the use of ../.rubocop.yml as a valid path)

[neonichu]

🔑

[KrauseFx]

Build failing though 😢

[KrauseFx]

Can we copy this over on the demand, so that we change the fastlane rules, it will use the latest rules?

[neonichu]

You mean like in a rake task?

[KrauseFx]

No, ideally we'd bundle the latest rubocop.yml with fastlane, so when the user run fastlane new_plugin, the latest config will be copied over to the new project. Does that make sense?

[neonichu]

But that's what is happening now? The issue is just that this is an additional copy of the .rubocop.yml inside the repo.

[KrauseFx]

Yeah, that's a big issue, we have to update both files when we update one?

[neonichu]

Yah, thought that was your idea in #4951 (comment). We could also change the gemspec to place the top-level rubocop config into the right place for the gem, I think.

[neonichu]

We could remove the copy and do this in the gemspec instead:

diff --git a/fastlane/fastlane.gemspec b/fastlane/fastlane.gemspec
index c73df81..45807b3 100644
--- a/fastlane/fastlane.gemspec
+++ b/fastlane/fastlane.gemspec
@@ -3,6 +3,9 @@ lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'fastlane/version'

+rubocop_config = File.expand_path('../../.rubocop.yml', __FILE__)
+`cp #{rubocop_config} #{lib}/fastlane/plugins/template`
+
 Gem::Specification.new do |spec|
   spec.name          = "fastlane"
   spec.version       = Fastlane::VERSION

Seems to work fine for both the development use case and building the gem.

[neonichu]

Just realised while building the gem works fine, the hidden files aren't packaged in general, so e.g. .gitignore isn't included when using the 1.93.1 release — this feels like a separate issue, though. Do you think it makes sense to tackle that before continuing with this PR?

[neonichu]

Invalid Dangerfile 😱

[KrauseFx]

It's not an invalid dangerfile, that's the error message

[!] Invalid `Dangerfile` file: git '--git-dir=/Users/distiller/fastlane/.git' '--work-tree=/Users/distiller/fastlane' diff '--numstat' 'danger_head' 'danger_base'  2>&1:fatal: ambiguous argument 'danger_base': unknown revision or path not in the working tree.

Could you try rebasing from master again? Sorry for all the troubles.

[neonichu]

✅

[KrauseFx]

Taking over now 🚀

[KrauseFx]

This is perfect, thanks for stealing my good commits!

[neonichu]

IM IN UR GITHUB, STEALING UR COMMITS