[Ready] Added new code signing guide #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
|
||
| Apple improved code signing a lot with the release of Xcode 8, the following has changed: | ||
|
|
||
| - No more `Fix Issue` button, instead all code signing processes run in the background and show the log right in Xcode |
|
Changes Unknown when pulling d00580b on codesigning-guide into * on master*. |
| @@ -0,0 +1,38 @@ | |||
| # Commong code signing issues | |||
|
|
||
| Using the `$(...)` notation, Xcode will use the provisioning profile matching the UUID, and fallback to `Automatic` if it's not provided. | ||
|
|
||
| If you use [fastlane](https://fastlane.tools) you don't have to do any extra work, since the environment variable for the latest profile are automatically set by [match](https://fastlane.tools/match) |
There was a problem hiding this comment.
"are automatically set" -> "is automatically set"
|
Looking great! Comments are mostly about cleaning up spelling & grammar 👍 |
| - [cert](https://fastlane.tools/cert) will make sure you have a valid certificate and its private key installed on the local machine | ||
| - [sigh](https://fastlane.tools/sigh) will make sure you have a valid provisioning profile installed locally, that matches the installed certificate | ||
|
|
||
| You basically add the following lines to your `Fastfile` |
KrauseFx
changed the title
| Add the following lines to your `Fastfile` | ||
|
|
||
| ```ruby | ||
| lane :beta do |
There was a problem hiding this comment.
Wondering if we should use a different lane name here? Maybe build?
|
👍 |
|
This looks 💯! I left one or two comments, but otherwise 🚀 ! |
| - [GettingStarted.md](GettingStarted.md#readme): Find the best code signing approach for your setup | ||
| - [XcodeProject.md](XcodeProject.md#readme): How to set up your Xcode project | ||
| - [Troubleshooting.md](Troubleshooting.md#readme): Helps you debug signing issues | ||
| - [CommonIssues.md](CommonIssues.md#readme): A list of some of the msot common signing issues and how to solve them |
There was a problem hiding this comment.
most is misspelled as msot here
KrauseFx
added a commit
that referenced
this pull request
Jul 16, 2016
* Added new code [signing guide](https://github.com/fastlane/fastlane/tree/master/fastlane/docs/Codesigning) (#5178) * Support multiple md5 hashes of the PackageApplication script to support multiple Xcode versions (#5391) * Support relative path like "~/file" (#5350) * Add warnings when using Xcode's 7 build options with legacy build api (#5229) * Deprecated provisioning_profile_path (#5106) * Proper escaping of codesigning identity (#5148) * Escape code signing identity * Add support for `rbenv` in `wrap_xcodebuild/xcbuild-safe.sh` (#4625) * Print out legacy information every time you run gym (#4890) * Fix gym with path with spaces (#4721)
Merged
KrauseFx
added a commit
that referenced
this pull request
Jul 16, 2016
* Added new code [signing guide](https://github.com/fastlane/fastlane/tree/master/fastlane/docs/Codesigning) (#5178) * Support multiple md5 hashes of the PackageApplication script to support multiple Xcode versions (#5391) * Support relative path like "~/file" (#5350) * Add warnings when using Xcode's 7 build options with legacy build api (#5229) * Deprecated provisioning_profile_path (#5106) * Proper escaping of codesigning identity (#5148) * Escape code signing identity * Add support for `rbenv` in `wrap_xcodebuild/xcbuild-safe.sh` (#4625) * Print out legacy information every time you run gym (#4890) * Fix gym with path with spaces (#4721)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to explore how things look like via https://github.com/fastlane/fastlane/tree/codesigning-guide/fastlane/docs/Codesigning