add shared logs base directory

[Ashton-W]

Adds FL_BUILDLOG_PATH environment variable to override the default base log path of ~/Library/Logs.

Half Implements #4989

---

Another PR will include changes to:

• gym
• scan
• snapshot
• fastlane/actions/xcodebuild

master...Ashton-W:aw-common-buildlog_path

[KrauseFx]

Please use File.expand() here

[Ashton-W]

You mean for both values or just the default with the ~? I left then unexpanded because they were in the places I call this from, the option defaults are unexpanded paths. For example gym prints a table of the options it's using and that table reads "~/Library/Logs/gym" if I expand it now it will be the complete path?

[Ashton-W]

Sorry, I wasn't clear, I'd like your feedback on this again @KrauseFx

[KrauseFx]

File.expand_path(ENV["FL_BUILDLOG_PATH"] || "~/Library/Logs") 👍

[KrauseFx]

This looks great. However you'll need to split this up to 2 PRs, one for fastlane_core, and one for the tools, which will fail until we pushed a new fastlane_core release

[Ashton-W]

OK. I've split up the commit and force pushed this PR to be part 1

[KrauseFx]

Perfect, thanks 👍

[Ashton-W]

Keep it mind, with the path now expanded all tools will go from this:

+----------------------+------------------------+
|             Summary for gym 1.6.4             |
+----------------------+------------------------+
| project              | ./test.xcodeproj       |
| scheme               | test                   |
| destination          | generic/platform=macOS |
| output_name          | test                   |
| clean                | false                  |
| output_directory     | .                      |
| silent               | false                  |
| use_legacy_build_api | false                  |
| buildlog_path        | ~/Library/Logs/gym     |
+----------------------+------------------------+

to something like this

+----------------------+-----------------------------------+
|             Summary for gym 1.6.4                        |
+----------------------+-----------------------------------+
| project              | ./test.xcodeproj                  |
| scheme               | test                              |
| destination          | generic/platform=macOS            |
| output_name          | test                              |
| clean                | false                             |
| output_directory     | .                                 |
| silent               | false                             |
| use_legacy_build_api | false                             |
| buildlog_path        | /Users/Felix/Library/Logs/gym     |
+----------------------+-----------------------------------+

[KrauseFx]

Ugh, that's not ideal, good point.

[Ashton-W]

Like the others helpers, we could instead put the onus on callers to expand the path as needed.

[Ashton-W]

@KrauseFx I took out the commit that expanded the path. Let's keep it in mind for Part 2.

[Ashton-W]

Would be great to get this in soon so I move on to part 2 🙋

[KrauseFx]

Sorry for the delay @Ashton-W, I'm reviewing your PR now 👍

[KrauseFx]

This is perfect, really sorry for the delay again, and I can't wait for step 2 👍

[KrauseFx]

Thanks, this is already in the latest release. This should be documented as well 👍