[Carthage] Add option to pass in specific dependencies to update #5500
Conversation
| @@ -31,6 +36,10 @@ def self.available_platforms | |||
| end | |||
|
|
|||
| def self.available_options | |||
| default_options + options | |||
There was a problem hiding this comment.
I was running into errors with the available_options size being too high on the Carthage class, so I simply split it into default_options, and options, which are concatenated in available_options. This is an okay workaround but maybe someone else has a better solution to abiding by the rubocop style enforcement?
There was a problem hiding this comment.
I assume you're talking about a rubocop style error? If so so you can disable the bot for this method using
Run rubocop -D to get the cop name and add
# rubocop:disable [bot name here]
def ...
# rubocop:enable [bot name here]
| FastlaneCore::ConfigItem.new(key: :dependencies, | ||
| description: "Carthage dependencies to update", | ||
| default_value: [], | ||
| is_string: false, |
There was a problem hiding this comment.
Please add type: Array, to the params for this ConfigItem. That should remove the need to manually verify the data type in the verify_block 👍
There was a problem hiding this comment.
Actually, we will take this as-is and do the change quickly on our end so that we can include it in today's release! 😄
There was a problem hiding this comment.
Awesome thanks so much! 😄
|
Nice addition - thanks! 👍 |
* Add the ability to specify a strategy for hockey action (#5514) * Fixup carthage dependencies option to be Array type (#5522) * [Carthage] Add option to pass in specific dependencies to update (#5500) * [Carthage] Ignore platform option case (#5504) * Remove initial confirmation prompt from init beta * Add fields and tests for `init beta` (#5516) * Checking the default team_id value in the Appfile. (#5478) * Also check for a default value from the Appfile (#5465) * [add_git_tag] Add commit option * Update code signing URL across the fastlane code base (#5451)
This enables the ability to pass in particular dependencies to
carthage update, and closes #5499.An optional array of strings can now be passed into the
carthagecommand as such:This enables a lane in the Fastfile to update particular dependencies under different circumstances.