Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cocoapods now recommends json file formats, so fastlane should support it #5869

Merged
merged 1 commit into from Aug 25, 2016
Merged

Cocoapods now recommends json file formats, so fastlane should support it #5869

merged 1 commit into from Aug 25, 2016

Conversation

maschall
Copy link
Contributor

No description provided.

@KrauseFx
Copy link
Member

Great PR, thanks @maschall. However the build fails:



  1) Fastlane Fastlane::FastFile Pod Push action generates the correct pod push command with a json file
     Failure/Error: end").runner.execute(:test)
     FastlaneCore::Interface::FastlaneError:
       Couldn't find file at path './fastlane/spec/fixtures/podspecs/test.podspec.json'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:80:in `rescue in valid?'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:76:in `valid?'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:61:in `verify!'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:65:in `block in verify_value_exists'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:59:in `each'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:59:in `verify_value_exists'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:43:in `initialize'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:31:in `new'
     # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:31:in `create'
     # ./lib/fastlane/configuration_helper.rb:8:in `parse'
     # ./lib/fastlane/runner.rb:181:in `block (2 levels) in execute_action'
     # ./lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
     # ./lib/fastlane/runner.rb:175:in `block in execute_action'
     # ./lib/fastlane/runner.rb:174:in `chdir'
     # ./lib/fastlane/runner.rb:174:in `execute_action'
     # ./lib/fastlane/runner.rb:100:in `trigger_action_by_name'
     # ./lib/fastlane/fast_file.rb:140:in `method_missing'
     # (eval):2:in `block in parsing_binding'
     # ./lib/fastlane/lane.rb:33:in `call'
     # ./lib/fastlane/runner.rb:49:in `block in execute'
     # ./lib/fastlane/runner.rb:45:in `chdir'
     # ./lib/fastlane/runner.rb:45:in `execute'
     # ./spec/actions_specs/pod_push_spec.rb:39:in `block (4 levels) in <top (required)>'

  2) Fastlane Fastlane::FastFile Pod Push action errors if the path file does not end with .podspec or .podspec.json
     Failure/Error: expect do
       expected Exception with "File must be a `.podspec` or `.podspec.json`", got #<FastlaneCore::Interface::FastlaneError: Couldn't find file at path './fastlane/spec/fixtures/podspecs/test.notpodspec'> with backtrace:
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:80:in `rescue in valid?'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:76:in `valid?'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/config_item.rb:61:in `verify!'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:65:in `block in verify_value_exists'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:59:in `each'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:59:in `verify_value_exists'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:43:in `initialize'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:31:in `new'
         # /Users/distiller/.fastlane_bundle/ruby/2.3.0/gems/fastlane_core-0.50.3/lib/fastlane_core/configuration/configuration.rb:31:in `create'
         # ./lib/fastlane/configuration_helper.rb:8:in `parse'
         # ./lib/fastlane/runner.rb:181:in `block (2 levels) in execute_action'
         # ./lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
         # ./lib/fastlane/runner.rb:175:in `block in execute_action'
         # ./lib/fastlane/runner.rb:174:in `chdir'
         # ./lib/fastlane/runner.rb:174:in `execute_action'
         # ./lib/fastlane/runner.rb:100:in `trigger_action_by_name'
         # ./lib/fastlane/fast_file.rb:140:in `method_missing'
         # (eval):2:in `block in parsing_binding'
         # ./lib/fastlane/lane.rb:33:in `call'
         # ./lib/fastlane/runner.rb:49:in `block in execute'
         # ./lib/fastlane/runner.rb:45:in `chdir'
         # ./lib/fastlane/runner.rb:45:in `execute'
         # ./spec/actions_specs/pod_push_spec.rb:50:in `block (5 levels) in <top (required)>'
         # ./spec/actions_specs/pod_push_spec.rb:49:in `block (4 levels) in <top (required)>'
     # ./spec/actions_specs/pod_push_spec.rb:49:in `block (4 levels) in <top (required)>'

@maschall
Copy link
Contributor Author

Yep, I forgot to add the untracked files, before git commit -am

@KrauseFx KrauseFx merged commit 6ee656f into fastlane:master Aug 25, 2016
@KrauseFx
Copy link
Member

This is great, thanks for your contribution @maschall 👍

asfalcone pushed a commit that referenced this pull request Aug 29, 2016
Update fastlane version
77123a6 
[13:44:59]: Changes since release 1.101.0:
* Added --keychain-path to sigh (#5934)
* Sigh/4397 extract entitlements from app (#5130)
* [fastlane] Switching lane shouldn't be green (#5914)
* Adds SCAN_GENERATED_PLIST_FILES variable to report all test summaries. (#5740)
* Adding danger_id and dangerfile params to Danger action (#5894)
* Updated tools with build logs to use common configured Logs directory. (#5881)
* [slack] Don't post the lane when using slack as one-off action (#5899)
* Fix lane name conflict when creating a new Fastfile (#5895)
* Cocoapods now recommends json file formats, so fastlane should support it (#5869)
* [fastlane][verify_xcode] Add an additional set of accepted codesign details for Xcode 8 (#5821) (#5822)
* Add shell escaping to Crashlytics path (#5870)
* Add a ROOT path constant for fastlane (#5855)
* Fixed issue where artefacts with parens () would not get copied because of the shell escaping (#5812)
* Remove new action link (#5814)
* Add link to Circle docs (#5801)
@asfalcone asfalcone mentioned this pull request Aug 29, 2016
Merged
asfalcone pushed a commit that referenced this pull request Aug 29, 2016
Update fastlane version (#5938)
b9abd45 
[13:44:59]: Changes since release 1.101.0:
* Added --keychain-path to sigh (#5934)
* Sigh/4397 extract entitlements from app (#5130)
* [fastlane] Switching lane shouldn't be green (#5914)
* Adds SCAN_GENERATED_PLIST_FILES variable to report all test summaries. (#5740)
* Adding danger_id and dangerfile params to Danger action (#5894)
* Updated tools with build logs to use common configured Logs directory. (#5881)
* [slack] Don't post the lane when using slack as one-off action (#5899)
* Fix lane name conflict when creating a new Fastfile (#5895)
* Cocoapods now recommends json file formats, so fastlane should support it (#5869)
* [fastlane][verify_xcode] Add an additional set of accepted codesign details for Xcode 8 (#5821) (#5822)
* Add shell escaping to Crashlytics path (#5870)
* Add a ROOT path constant for fastlane (#5855)
* Fixed issue where artefacts with parens () would not get copied because of the shell escaping (#5812)
* Remove new action link (#5814)
* Add link to Circle docs (#5801)
@fastlane fastlane locked and limited conversation to collaborators Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
tool: action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maschall @KrauseFx