Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android support to DeployGate action #6166

Merged
merged 1 commit into from Dec 29, 2016

Conversation

tomorrowkey
Copy link
Contributor

Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:

  • Run rspec for all tools you modified
  • Run rubocop -a to ensure the code style is valid
  • We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

Before submitting a pull request, we appreciate if you create an issue first to discuss the change 👍


Upgrade the Deploygate action.
Support Uploading apk file to DeployGate. Please review this 🙏
cc: @tnj

ref: #38

req = Net::HTTP::Post::Multipart.new(url.path,
file: UploadIO.new(apk, 'application/octet-stream', File.basename(apk.path)),
token: options[:api_token]
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align ) with (.
Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.

apk = File.new(options[:apk])

req = Net::HTTP::Post::Multipart.new(url.path,
file: UploadIO.new(apk, 'application/octet-stream', File.basename(apk.path)),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, before we can review it, please make sure the code style validation and tests pass

@asfalcone
Copy link
Contributor

@tomorrowkey The error on CI is currently

bundle exec rspec --format documentation --format j --out rspec_logs.json --format RspecJunitFormatter --out /tmp/circle-junit.BjFXdfm/rspec/fastlane-junit.xml
[Coveralls] Using SimpleCov's default settings.
NameError: undefined method `parse_response' for class `#<Class:Fastlane::Actions::DeploygateAction::UploaderBase>'
  /Users/distiller/fastlane/fastlane/lib/fastlane/actions/deploygate.rb:81:in `private_class_method'
  /Users/distiller/fastlane/fastlane/lib/fastlane/actions/deploygate.rb:81:in `<class:UploaderBase>'

@hjanuschka
Copy link
Collaborator

@asfalcone tests pass now i think its a good addition for the android users, how about merging it?

@mfurtak mfurtak self-assigned this Nov 28, 2016
@mfurtak
Copy link
Contributor

mfurtak commented Nov 29, 2016

I think this is great, but we need to coordinate with the changes in #6991, which I believe will conflict

@mpirri
Copy link
Contributor

mpirri commented Dec 21, 2016

As per @mfurtak's comment above, there are conflicts that need to be cleaned up before we can merge this. We'd love to get this added for Android users, can you rebase, @tomorrowkey ?

@tomorrowkey
Copy link
Contributor Author

Okay, wait for a minute...

@tomorrowkey
Copy link
Contributor Author

1a4e908 is not rebased changes.
Thanks to removing shenzhen dependency, changes has been became simply.

@tomorrowkey
Copy link
Contributor Author

Why CI was faild? What shoud I do?

@KrauseFx KrauseFx changed the title Support Android Add Android support to DeployGate action Dec 26, 2016
@KrauseFx
Copy link
Member

It seems like coveralls failed, I'll try to re-trigger CI 👍

@tomorrowkey
Copy link
Contributor Author

Thanks. CI is now green 😎

@KrauseFx
Copy link
Member

🚀

@KrauseFx KrauseFx merged commit 2226feb into fastlane:master Dec 29, 2016
@KrauseFx KrauseFx mentioned this pull request Jan 3, 2017
@fastlane fastlane locked and limited conversation to collaborators Mar 30, 2017
@tomorrowkey tomorrowkey deleted the deploygate/support-android branch January 12, 2022 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants