-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android support to DeployGate action #6166
Add Android support to DeployGate action #6166
Conversation
req = Net::HTTP::Post::Multipart.new(url.path, | ||
file: UploadIO.new(apk, 'application/octet-stream', File.basename(apk.path)), | ||
token: options[:api_token] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align ) with (.
Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
apk = File.new(options[:apk]) | ||
|
||
req = Net::HTTP::Post::Multipart.new(url.path, | ||
file: UploadIO.new(apk, 'application/octet-stream', File.basename(apk.path)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the parameters of a method call if they span more than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, before we can review it, please make sure the code style validation and tests pass
@tomorrowkey The error on CI is currently
|
@asfalcone tests pass now i think its a good addition for the android users, how about merging it? |
I think this is great, but we need to coordinate with the changes in #6991, which I believe will conflict |
As per @mfurtak's comment above, there are conflicts that need to be cleaned up before we can merge this. We'd love to get this added for Android users, can you rebase, @tomorrowkey ? |
Okay, wait for a minute... |
511eea6
to
656bc8a
Compare
656bc8a
to
1a4e908
Compare
1a4e908 is not rebased changes. |
Why CI was faild? What shoud I do? |
It seems like coveralls failed, I'll try to re-trigger CI 👍 |
Thanks. CI is now green 😎 |
🚀 |
Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:
rspec
for all tools you modifiedrubocop -a
to ensure the code style is validBefore submitting a pull request, we appreciate if you create an issue first to discuss the change 👍
Upgrade the Deploygate action.
Support Uploading apk file to DeployGate. Please review this 🙏
cc: @tnj
ref: #38