Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshot to support both Swift 3 and Swift 2.3 #6218

Merged
merged 1 commit into from Sep 20, 2016
Merged

Update snapshot to support both Swift 3 and Swift 2.3 #6218

merged 1 commit into from Sep 20, 2016

Conversation

KrauseFx
Copy link
Member

screenshot 2016-09-20 17 19 30

@KrauseFx KrauseFx mentioned this pull request Sep 20, 2016
Closed
mfurtak
mfurtak approved these changes Sep 20, 2016
View reviewed changes
Copy link
Contributor

@mfurtak mfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KrauseFx KrauseFx merged commit 4df6ec7 into master Sep 20, 2016
@KrauseFx KrauseFx deleted the snapshot-swift-3 branch September 20, 2016 22:21
@KrauseFx
Copy link
Member Author

We should do a release for this

@huguesbr
Copy link
Contributor

@KrauseFx isn't it Swift 3 only? it doesn't seem to have any compiler check for 2.3 vs 3.0? doesn't work for me on 2.3

@huguesbr
Copy link
Contributor

huguesbr commented Oct 17, 2016 •
edited

Hum, in fact didn't look carefully enought, I thought it was via compiler directive, but it's 2 differents file... snapshot update didn't create both file, but backuping old Snapfile and running snapshot init did regenerate both. 👍

@fastlane fastlane locked and limited conversation to collaborators Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfurtak mfurtak mfurtak approved these changes

Assignees
No one assigned
Labels
tool: snapshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KrauseFx @huguesbr @mfurtak