-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in plugin-badge.svg #6451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kiliankoe Can you explain the change that you made in this PR? Maybe a side by side screenshot? Thanks 👍 |
asfalcone
approved these changes
Oct 7, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I just didn't look at the rich diff! Thanks for the fix 🚀
And thanks for the merge 😊 |
Ha, nice catch 👍 |
KrauseFx
added a commit
that referenced
this pull request
Oct 10, 2016
* Improve team selection for both iTunes Connect and the Dev Portal * Fix update_project_team with Xcode 8 (#6453) * Update team selection and documentation across all fastlane actions (#6444) * Losen up external fastlane dependencies (#6486) * Update spaceship dependencies (#6485) * Verify docs on pull requests and releases (#6475) * Ensure git branch and git pull before verifying version number (#6484) * Losen up dependencies of subtools (#6461) * Improve formatting of git_commit code samples (#6476) * Fix typo in plugin-badge.svg (#6451) * Improve output of changelog action (#6434)
KrauseFx
added a commit
that referenced
this pull request
Oct 11, 2016
* Improve team selection for both iTunes Connect and the Dev Portal * Fix update_project_team with Xcode 8 (#6453) * Update team selection and documentation across all fastlane actions (#6444) * Losen up external fastlane dependencies (#6486) * Update spaceship dependencies (#6485) * Verify docs on pull requests and releases (#6475) * Ensure git branch and git pull before verifying version number (#6484) * Losen up dependencies of subtools (#6461) * Improve formatting of git_commit code samples (#6476) * Fix typo in plugin-badge.svg (#6451) * Improve output of changelog action (#6434)
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec
for all tools you modifiedrubocop -a
to ensure the code style is validI hope it's ok for not running the tests or rubocop on this.