Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in plugin-badge.svg #6451

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Conversation

kiliankoe
Copy link
Contributor

@kiliankoe kiliankoe commented Oct 7, 2016

  • Run rspec for all tools you modified
  • Run rubocop -a to ensure the code style is valid
  • We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

I hope it's ok for not running the tests or rubocop on this.

@asfalcone
Copy link
Contributor

@kiliankoe Can you explain the change that you made in this PR? Maybe a side by side screenshot? Thanks 👍

@kiliankoe
Copy link
Contributor Author

Github's rich diff does a better job than I could^^

screen shot 2016-10-07 at 16 49 34

I did nothing else but fix the typo in the original. And if I'm not mistaken, generated plugins link the badge from this repo, so that should fix the typos in all of them as well.

Copy link
Contributor

@asfalcone asfalcone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I just didn't look at the rich diff! Thanks for the fix 🚀

@asfalcone asfalcone merged commit ccfb329 into fastlane:master Oct 7, 2016
@kiliankoe
Copy link
Contributor Author

And thanks for the merge 😊

@kiliankoe kiliankoe deleted the patch-1 branch October 7, 2016 15:01
@KrauseFx
Copy link
Member

KrauseFx commented Oct 7, 2016

Ha, nice catch 👍

KrauseFx added a commit that referenced this pull request Oct 10, 2016
* Improve team selection for both iTunes Connect and the Dev Portal
* Fix update_project_team with Xcode 8 (#6453)
* Update team selection and documentation across all fastlane actions (#6444)
* Losen up external fastlane dependencies (#6486)
* Update spaceship dependencies (#6485)
* Verify docs on pull requests and releases (#6475)
* Ensure git branch and git pull before verifying version number (#6484)
* Losen up dependencies of subtools (#6461)
* Improve formatting of git_commit code samples (#6476)
* Fix typo in plugin-badge.svg (#6451)
* Improve output of changelog action (#6434)
KrauseFx added a commit that referenced this pull request Oct 11, 2016
* Improve team selection for both iTunes Connect and the Dev Portal
* Fix update_project_team with Xcode 8 (#6453)
* Update team selection and documentation across all fastlane actions (#6444)
* Losen up external fastlane dependencies (#6486)
* Update spaceship dependencies (#6485)
* Verify docs on pull requests and releases (#6475)
* Ensure git branch and git pull before verifying version number (#6484)
* Losen up dependencies of subtools (#6461)
* Improve formatting of git_commit code samples (#6476)
* Fix typo in plugin-badge.svg (#6451)
* Improve output of changelog action (#6434)
@fastlane fastlane locked and limited conversation to collaborators Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants