[#6595] Add exit_on_test_failure option to allow copying screenshots … #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enshots after test failure
lalunamel
commented
Oct 18, 2016
| @@ -225,7 +225,11 @@ def run_tests(device_serial, test_classes_to_use, test_packages_to_use) | |||
| print_all: true, | |||
| print_command: true) | |||
|
|
|||
| UI.user_error!("Tests failed", show_github_issues: false) if test_output.include?("FAILURES!!!") | |||
| if @config[:exit_on_test_failure] | |||
There was a problem hiding this comment.
I would wrap this block in the if test_output.include?("FAILURES!!!") but rubocop then complains I need to include a next to skip the current iteration of the loop (which is not necessary)
| @@ -8,12 +8,60 @@ | |||
| @runner = Screengrab::Runner.new(mock_executor, config, mock_android_environment) | |||
| end | |||
|
|
|||
| def set_mock_adb_response(command, mock_response) | |||
| def mock_adb_response_for_command(command, mock_response) | |||
There was a problem hiding this comment.
Again, rubocop complains that I can't have a method with the word 'set' in it that's a setter. (even though that existed before this commit)
asfalcone
approved these changes
Jan 3, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.