Add missing device names for iPhone7 and iPhone7Plus #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohayon
approved these changes
Oct 25, 2016
mpirri
force-pushed
the
feature/fix-iPhone7-snapshot
branch
from
9606fb7
to
243cb06
Compare
mpirri
pushed a commit
that referenced
this pull request
Oct 27, 2016
* Add missing device names for iPhone7 and iPhone7Plus (#6741) * Update internal dependencies (#6682) * Update fastlane tagline (#6645) * Update fastlane_core dependencies (#6615) * Update internal dependencies (#6599) * Update Snapshot url in runner file (#6609) * Update rubocop and update styling rules (#6573) * Fix typo (#6596) * Update SnapshotHelper.swift (#6581) * Show Xcode path in summary table (#6472) * Update xcpretty dependency (#6510) * Losen up dependencies of subtools (#6461) * Add link to new fastlane docs (#6447) * Replace `snapshot` with _snapshot_ (#6448) * Fix information about how to access the current language (#6449)
mpirri
added a commit
that referenced
this pull request
Oct 27, 2016
* Add missing device names for iPhone7 and iPhone7Plus (#6741) * Update internal dependencies (#6682) * Update fastlane tagline (#6645) * Update fastlane_core dependencies (#6615) * Update internal dependencies (#6599) * Update Snapshot url in runner file (#6609) * Update rubocop and update styling rules (#6573) * Fix typo (#6596) * Update SnapshotHelper.swift (#6581) * Show Xcode path in summary table (#6472) * Update xcpretty dependency (#6510) * Losen up dependencies of subtools (#6461) * Add link to new fastlane docs (#6447) * Replace `snapshot` with _snapshot_ (#6448) * Fix information about how to access the current language (#6449)
nareshsvs
pushed a commit
to nareshsvs/fastlane
that referenced
this pull request
Oct 28, 2016
* master_original: (286 commits) [fastlane] Don’t ask for clipboard on non-interactive shell (fastlane#6782) [spaceship] Fix access control of `mac?` method in upload_file (fastlane#6783) [scan] Handle single scheme Xcode projects (fastlane#6637) spaceship doesn't have access to FastlaneCore::Helper (fastlane#6778) [snapshot] Version Bump (fastlane#6777) Update "spaceship in use" section (fastlane#6763) Add instructions for `fastlane env` in fastlane issue reporter (fastlane#6775) [spaceship] Add instructions on how to use 2factor on non-interactive shells (fastlane#6764) Improve grammar for gym message, and provide sample usage (fastlane#6776) [spaceship] Skips removing of alpha channel on non-Mac hosts (fastlane#6767) make sure that languages are available on iTC if you have localized screenshots (fastlane#6760) make use of the rollout option when promoting from a track to the sta… (fastlane#6502) [fastlane] Remove extra * in env printer (fastlane#6745) Add missing device names for iPhone7 and iPhone7Plus (fastlane#6741) [deliver] Version bump (fastlane#6744) [fastlane] Improve code style of xcversion (fastlane#6740) [fastlane] Version bump (fastlane#6723) Update internal dependencies (fastlane#6724) Fix spelling mistake (fastlane#6713) Add `SPACESHIP_TIMEOUT` environment variable to change the default timeout (fastlane#6712) ... # Conflicts: # match/lib/match/git_helper.rb # match/lib/match/runner.rb # match/lib/match/version.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6376 - Screenshots on iPhone 7 and iPhone 7 Plus aren't working.
Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:
bundle exec rspecfrom the subdirectory of each tool you modified. Alternatively, runrake test_allfrom the root directory.bundle exec rubocop -ato ensure the code style is validBefore submitting a pull request, we appreciate if you create an issue first to discuss the change 👍