Issue6765 proxy #6817
Merged
Issue6765 proxy #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_form don't use ENV proxy settings (#6765)
milch
requested changes
Nov 1, 2016
| http_conn = Net::HTTP.new(uri.host, uri.port) | ||
| http_conn.use_ssl = true | ||
| result = http_conn.request_get(uri.path) | ||
| raise "#{result.message} (#{result.code})" unless result.kind_of? Net::HTTPSuccess |
There was a problem hiding this comment.
Please use UI.crash! instead of raise as described here: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/UI.md
| @@ -72,8 +72,12 @@ def download_android_tools | |||
| begin | |||
| UI.important("Downloading Crashlytics Support Library - this might take a minute...") | |||
|
|
|||
| result = Net::HTTP.get(URI(url)) | |||
| File.write(zip_path, result) | |||
| uri = URI(url) | |||
There was a problem hiding this comment.
It would be nice to mention (with a link to the ruby issue) why it is done that way in a comment. Otherwise someone might come along later, wonder why it is done this way, and change it back.
milch
approved these changes
Nov 2, 2016
|
Beautiful 💯 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:
bundle exec rspecfrom the subdirectory of each tool you modified. Alternatively, runrake test_allfrom the root directory.bundle exec rubocop -ato ensure the code style is validBefore submitting a pull request, we appreciate if you create an issue first to discuss the change 👍
PR for issue #6765