Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call set_info_plist_value resulting in bplist file #7188

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

sainttail
Copy link
Contributor

Refer to #6810

Since, I'm not too familiar with ruby and this issue happens on some specific machines (which happens to be me). So I try to fix it.

This PR seem like it solve that problem but I don't know why. Can someone explain this to me?

Thanks.

Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:

  • Run bundle exec rspec from the subdirectory of each tool you modified. Alternatively, run rake test_all from the root directory.
  • Run bundle exec rubocop -a to ensure the code style is valid
  • Read the Contribution Guidelines
  • We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

Before submitting a pull request, we appreciate if you create an issue first to discuss the change 👍

@mfurtak mfurtak changed the title Fix call set_info_plist_value result in bplist file Fix call set_info_plist_value resulting in bplist file Nov 28, 2016
Copy link
Contributor

@mfurtak mfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this change fixes things relative to your sample project that exhibits the problem.

The two calls should be equivalent, so I think this change is fine. The fact that they're resulting in different outcomes is confounding 😫

@mfurtak mfurtak merged commit b537c9e into fastlane:master Nov 28, 2016
@asfalcone asfalcone mentioned this pull request Nov 29, 2016
@fastlane fastlane locked and limited conversation to collaborators Feb 27, 2017
@sainttail sainttail deleted the fix-set-info-plist-value branch January 15, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants