Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message when sonar-scanner isn't installed #7214

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

Palleas
Copy link
Contributor

@Palleas Palleas commented Nov 28, 2016

Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes:

  • Run bundle exec rspec from the subdirectory of each tool you modified. Alternatively, run rake test_all from the root directory.
  • Run bundle exec rubocop -a to ensure the code style is valid
  • Read the Contribution Guidelines
  • We currently don't accept new actions, please publish a plugin instead, more information in Plugins.md

The formula is now longer sonar-runner but sonar-scanner see the pull request in https://github.com/Homebrew/homebrew-core/search?q=sonar-runner&type=Issues&utf8=%E2%9C%93

@Palleas Palleas changed the title Update message when sonar-runner isn't installed Update message when sonar-scanner isn't installed Nov 28, 2016
@milch
Copy link
Collaborator

milch commented Nov 28, 2016

For posterity, sonar-runner was removed from brew here and replaced by sonar-scanner here

Copy link
Collaborator

@milch milch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@milch milch merged commit 7f6c80e into fastlane:master Nov 28, 2016
@Palleas Palleas deleted the patch-1 branch November 28, 2016 21:56
@asfalcone asfalcone mentioned this pull request Nov 29, 2016
@fastlane fastlane locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants