New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate fastlane to be a mono gem #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise all of fastlane will have to be pulled in just to include version information
KrauseFx
commented
Dec 14, 2016
@@ -26,7 +26,6 @@ module Fastlane | |||
Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore | |||
UI = FastlaneCore::UI | |||
ROOT = Pathname.new(File.expand_path('../..', __FILE__)) | |||
DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this in fastlane.rb
, it makes more sense to be there, as it's not version specific 👍
#7479) * implement commands_generator for spaceship * Remove watchbuild * Fix for spaceauth executable * Pass parrameter list to exec Otherwise `spaceauth -u abc@a.de` thinks `-u abc@a.de` is a single param * Add comment to explain exec invocation
…7496) * Update install instructions to use `fastlane` instead of other gems * Update snapshot, sigh, match and gym instructions for mono gem * Update supply, spaceship, screengrab, scan, produce and pilot usage instructions * Update pem and gym instructions * Update readmes
This was still using the old API to fetch an asset file
milch
approved these changes
Dec 15, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄🚀🤖
# Conflicts: # cert/bin/cert # cert/cert.gemspec # cert/lib/cert/version.rb # credentials_manager/bin/fastlane-credentials # credentials_manager/credentials_manager.gemspec # credentials_manager/lib/credentials_manager/version.rb # deliver/bin/deliver # deliver/deliver.gemspec # deliver/lib/deliver/version.rb # fastlane.gemspec # fastlane_core/fastlane_core.gemspec # fastlane_core/lib/fastlane_core/version.rb # frameit/bin/frameit # frameit/frameit.gemspec # frameit/lib/frameit/version.rb # gym/bin/gym # gym/bin/💪 # gym/gym.gemspec # gym/lib/gym/version.rb # match/bin/match # match/lib/match/version.rb # match/match.gemspec # pem/bin/pem # pem/lib/pem/version.rb # pem/pem.gemspec # pilot/bin/pilot # pilot/lib/pilot/version.rb # pilot/pilot.gemspec # produce/bin/produce # produce/lib/produce/version.rb # produce/produce.gemspec # scan/bin/scan # scan/lib/scan/version.rb # scan/scan.gemspec # screengrab/bin/screengrab # screengrab/screengrab.gemspec # sigh/bin/sigh # sigh/lib/sigh/version.rb # sigh/sigh.gemspec # snapshot/bin/snapshot # snapshot/lib/snapshot/version.rb # snapshot/snapshot.gemspec # spaceship/bin/spaceauth # spaceship/bin/spaceship # spaceship/lib/spaceship/version.rb # spaceship/spaceship.gemspec # supply/bin/supply # supply/lib/supply/version.rb # supply/supply.gemspec # watchbuild/watchbuild.gemspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #7412