Print a message explaining how to quickly open links on macOS #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrauseFx
approved these changes
Jan 12, 2017
|
Not sure what's up with Circle for this PR, I guess it's due to the GitHub downtime? |
|
fantastic branch name 👍 how do we re-trigger ci? (can you push a commit?) |
mfurtak
reviewed
Jan 13, 2017
|
|
||
| def print_open_link_hint(newline = false) | ||
| puts "" if newline | ||
| puts "🔗 You can ⌘ + double-click on links to open them directly in your browser." if /darwin/ =~ RUBY_PLATFORM |
There was a problem hiding this comment.
If we need another change to re-trigger CI... can we replace the end check with Helper.mac?
Because ⌘ + double-click is much faster than 1. double-click + drag 2. ⌘ + C 3. ⌘ + n × ⇥ 4. ⌘ + T 5. ⌘ + V 6. ⏎ A remake of orta/gh_inspector#14 for the custom inspector reporter.
|
Beautiful, thanks @0xced 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
A remake of orta/gh_inspector#14 for the custom inspector reporter.
Motivation and Context
Because ⌘ + double-click is much faster than