Support loading multiple dotenvs #7943
Conversation
lacostej
force-pushed
the
multiple_dot_envs
branch
from
040cccf
to
732aa4c
Compare
lacostej
force-pushed
the
multiple_dot_envs
branch
from
732aa4c
to
da2275d
Compare
| @@ -90,6 +90,9 @@ lane :deploy_all do | |||
| end | |||
| ``` | |||
|
|
|||
| And you can combine multiple envs in one go | |||
| Ex: `fastlane build --env app1,env1,env2` will use `.env.app1` `.env.env1` and `.env.env2` | |||
There was a problem hiding this comment.
This should also be synced with https://github.com/fastlane/docs/blob/master/docs/faqs.md
There was a problem hiding this comment.
Those file look awfully similar. Are they meant to be the same? Why not sync them automatically?
There was a problem hiding this comment.
I will prepare a patch once this one is accepted.
| env_file = File.join(base_path, ".env.#{env}") | ||
| UI.success "Loading from '#{env_file}'" | ||
| Dotenv.overload(env_file) | ||
| if envs |
There was a problem hiding this comment.
Can we just use return if envs.nil?
| if env | ||
| return unless envs | ||
|
|
||
| envs = envs.split(",") # multiple envs? |
There was a problem hiding this comment.
Maybe call the arg "env_descriptor" or similar? Overwriting the var makes this harder to scan read
| # Loads .env file for the environment(s) passed in through options | ||
| envs = [envs] unless envs.kind_of? Array | ||
|
|
||
| envs.each do |env| | ||
| env_file = File.join(base_path, ".env.#{env}") |
There was a problem hiding this comment.
I'd break this out into a load_env(env) fn for readability, because right now this fn is getting pretty complex
| expect(ENV['DOTENV']).to eq(expected_value) | ||
| ff = Fastlane::LaneManager.load_dot_env(envs) | ||
| ENV.each do |k, v| | ||
| puts "#{k} = #{v}" |
There was a problem hiding this comment.
This should be removed before merging
lacostej
force-pushed
the
multiple_dot_envs
branch
from
02dc2a4
to
dfa7e44
Compare
lacostej
force-pushed
the
multiple_dot_envs
branch
from
dfa7e44
to
08e0df7
Compare
Things I am a bit unsure of:
--envinto--envsActions.lane_context[Actions::SharedValues::ENVIRONMENT]should a new one be added with an array? should the original one keep the CSV passed on the CL?