produce: fix data_protection in enabled features #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mfurtak
suggested changes
Jan 23, 2017
hjanuschka
force-pushed
the
produce_fix1
branch
from
4fc148b
to
65cdcfd
Compare
|
@mfurtak good idea, however produce does not have yet any specs. |
mgrebenets
previously approved these changes
Jan 23, 2017
hjanuschka
commented
Jan 23, 2017
| stub_request(:post, "https://idmsa.apple.com/appleauth/auth/signin?widgetKey=e0b80c3bf78523bfe80974d320935bfa30add02e1bff88ec2166c6bd5a706c42"). | ||
| with(body: "{\"accountName\":\"helmut@xxx.com\",\"password\":\"xxxx\",\"rememberMe\":true}", | ||
| headers: { 'Accept' => 'application/json, text/javascript', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Spaceship 2.9.0', 'X-Requested-With' => 'XMLHttpRequest' }). | ||
| to_return(status: 200, body: "", headers: {}) |
There was a problem hiding this comment.
stub will be replaced, once the create_new_app is called.
| # this does not get triggerd - HELP | ||
| # i would return true here, and check if the `enabled_features` argument to create_new_app is the expected one | ||
| # but it just does not get called. | ||
| expect(Produce::DeveloperCenter).to receive(:create_new_app).with(anything).and_return(false) |
added 2 commits
January 23, 2017 16:31
|
@mgrebenets , @mfurtak all good now - tests pass 馃憤 |
mfurtak
reviewed
Jan 23, 2017
| username: "helmut@januschka.com", | ||
| enabled_features: { data_protection: "complete" }, | ||
| skip_itc: true | ||
| } |
There was a problem hiding this comment.
While this works, it's a little sketchy since the real type of this object should be Configuration. It's more common to set this up like:
Produce.config = FastlaneCore::Configuration.create(Produce::Options.available_options, {
username: "helmut@januschka.com",
enabled_features: { data_protection: "complete" },
skip_itc: true
})
mfurtak
reviewed
Jan 23, 2017
| @@ -0,0 +1 @@ | |||
| require_relative "stubbing" | |||
There was a problem hiding this comment.
let's remove this and the stubbing.rb until we need them 馃憤
|
@mfurtak feedback addressed. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7954
.onis nil on that option! 馃槩