-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundler dependency to be more flexible #7964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KrauseFx possible to go lower than |
@summera Why? We haven't tested it with a lower version, we use the bundler API directly when the user has plugins enabled for their project. |
Got it. So is I'm in a situation where the default bundler version in my AWS Elastic Beanstalk environment is lower than |
@summera I'm unsure, I haven't tested it below that version, that's why we require it. If you can try using it with an older version, and make sure plugin installation and adding new plugins work, I'm ok with reducing the minimum version more 👍 |
We can merge this for now, as it's already an improvement like this 👍 |
@KrauseFx Cool sounds good 👍 . I'll get back to you on reducing the min version. Thanks again! |
Thanks 👍 |
Fixes #7963