Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler dependency to be more flexible #7964

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Conversation

KrauseFx
Copy link
Member

Fixes #7963

Copy link
Collaborator

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@summera
Copy link
Contributor

summera commented Jan 23, 2017

@KrauseFx possible to go lower than 1.12? For example: ~> 1.0?

@KrauseFx
Copy link
Member Author

@summera Why? We haven't tested it with a lower version, we use the bundler API directly when the user has plugins enabled for their project.

@summera
Copy link
Contributor

summera commented Jan 24, 2017

Got it. So is >= 1.12 required for fastlane plugins to work or you're unsure?

I'm in a situation where the default bundler version in my AWS Elastic Beanstalk environment is lower than 1.12 (1.9.6). So I'm wondering if it's possible to make the requirement less strict by allowing lower versions of bundler for people in similar situations.

@KrauseFx
Copy link
Member Author

@summera I'm unsure, I haven't tested it below that version, that's why we require it. If you can try using it with an older version, and make sure plugin installation and adding new plugins work, I'm ok with reducing the minimum version more 👍

@KrauseFx KrauseFx merged commit 0e092ff into master Jan 24, 2017
@KrauseFx
Copy link
Member Author

We can merge this for now, as it's already an improvement like this 👍

@KrauseFx KrauseFx deleted the KrauseFx-patch-5 branch January 24, 2017 04:33
@summera
Copy link
Contributor

summera commented Jan 24, 2017

@KrauseFx Cool sounds good 👍 . I'll get back to you on reducing the min version. Thanks again!

@KrauseFx
Copy link
Member Author

Thanks 👍

@KrauseFx KrauseFx mentioned this pull request Jan 24, 2017
@fastlane fastlane locked and limited conversation to collaborators Apr 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants